From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 2/2] at803x: double check SGMII side autoneg Date: Tue, 23 May 2017 18:07:22 +0200 Message-ID: <20170523160722.GC21169@lunn.ch> References: <1477305654-11328-1-git-send-email-zefir.kurtisi@neratec.com> <1477305654-11328-3-git-send-email-zefir.kurtisi@neratec.com> <66de55da-7a5c-68b8-50d5-cab313ec0d6f@codeaurora.org> <20170522210927.GR29447@lunn.ch> <0d9b30e5-40f3-82ba-a44a-2eb25b8d3094@codeaurora.org> <20170522213206.GT29447@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Zefir Kurtisi , netdev@vger.kernel.org, f.fainelli@gmail.com, David Miller , Manoj Iyer , jhugo@codeaurora.org To: Timur Tabi Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:41682 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934937AbdEWQHb (ORCPT ); Tue, 23 May 2017 12:07:31 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, May 23, 2017 at 10:54:57AM -0500, Timur Tabi wrote: > On 05/22/2017 04:32 PM, Andrew Lunn wrote: > >> I'll have to test this, but what do I do if I don't get another interrupt? > > It probably means interrupts cannot be used. Poll it. > > I will test that to see what happens, but I believe the real problem is that > the at803x driver is lying when it says that the link is not okay. I think > the link is okay, and that's why I'm not getting any more interrupts. I > don't think I should have to drop interrupt support in my MAC driver because > one specific PHY driver is broken. If it turns out the PHY hardware is broken, the phy driver itself can force it back to polling by setting phydev->irq to PHY_POLL in its probe() function. Andrew