From: James Cameron <quozl@laptop.org>
To: Julian Scheel <julian@jusst.de>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@kernel.org, ckeepax@opensource.wolfsonmicro.com,
lars@metafoo.de
Subject: Re: [PATCH] ASoC: Add pcm9211 driver
Date: Wed, 24 May 2017 07:16:24 +1000 [thread overview]
Message-ID: <20170523211624.GA3245@us.netrek.org> (raw)
In-Reply-To: <20170523090931.9697-1-julian@jusst.de>
On Tue, May 23, 2017 at 11:09:31AM +0200, Julian Scheel wrote:
> This adds a driver for the TI PCM9211 digital audio interfaces
> transceiver. The driver currently only handles the receiver aspect of
> the chip and supports only control of the primary I2S (MAIN) output
> port. Support for AUX output is trivial to add, but wasn't done due to
> missing hardware for testing. The same goes for the transmitter
> functionality.
> The driver uses some extra device-tree fields to allow configuration of
> pin functions directly out of this driver.
>
> Signed-off-by: Julian Scheel <julian@jusst.de>
> ---
> .../devicetree/bindings/sound/pcm9211.txt | 118 ++
> MAINTAINERS | 6 +
> include/dt-bindings/sound/pcm9211.h | 55 +
> sound/soc/codecs/Kconfig | 10 +
> sound/soc/codecs/Makefile | 4 +
> sound/soc/codecs/pcm9211-i2c.c | 65 +
> sound/soc/codecs/pcm9211.c | 1357 ++++++++++++++++++++
> sound/soc/codecs/pcm9211.h | 206 +++
> 8 files changed, 1821 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/pcm9211.txt
> create mode 100644 include/dt-bindings/sound/pcm9211.h
> create mode 100644 sound/soc/codecs/pcm9211-i2c.c
> create mode 100644 sound/soc/codecs/pcm9211.c
> create mode 100644 sound/soc/codecs/pcm9211.h
>
> [...]
> diff --git a/sound/soc/codecs/pcm9211.c b/sound/soc/codecs/pcm9211.c
> new file mode 100644
> index 000000000000..0ab4ad551df8
> --- /dev/null
> +++ b/sound/soc/codecs/pcm9211.c
> @@ -0,0 +1,1357 @@
> [...]
> +int pcm9211_probe(struct device *dev, struct regmap *regmap)
> +{
> [...]
> + priv->int0 = devm_gpiod_get_optional(dev, "int0", GPIOD_IN);
> + if (IS_ERR(priv->reset)) {
> + ret = PTR_ERR(priv->reset);
> + dev_err(dev, "Failed to get reset gpio: %d\n", ret);
> + return ret;
> + }
In above block; reset should be int0, three lines affected.
--
James Cameron
http://quozl.netrek.org/
next prev parent reply other threads:[~2017-05-23 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 9:09 [PATCH] ASoC: Add pcm9211 driver Julian Scheel
2017-05-23 21:16 ` James Cameron [this message]
2017-05-24 7:44 ` Julian Scheel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523211624.GA3245@us.netrek.org \
--to=quozl@laptop.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=julian@jusst.de \
--cc=lars@metafoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.