All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com
Cc: fio@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 0/2] configure
Date: Tue, 23 May 2017 20:01:16 -0600	[thread overview]
Message-ID: <20170524020114.GA26621@kernel.dk> (raw)
In-Reply-To: <20170523184358.48088-1-tkusumi@tuxera.com>

On Tue, May 23 2017, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
> 
> Regarding below, whatever I tried ended up just adding unnecessary
> complexity on runtime, so I'd like to submit two patches that weren't
> picked up in the previous series of commits for now. These two are just
> cleanups.
> 
> Printing the fs name to error messages for those that compiles but may
> fail on runtime could be good enough to make it less insane, however
> detecting the fs type from a given regular file path is another less
> trivial thing, especially if we want to do it on all supported platforms
> (I think du(1) does this).
> 
>  http://www.spinics.net/lists/fio/msg05807.html
>  >> Yes, so the next one 2/11 actually mostly reverts this, and replace it
>  >> with runtime check, so that it works not only with this specific
>  >> NetBSD/UFS case, but also for e.g. Linux fs (something other than
>  >> ext4, XFS, etc).
>  >> I wasn't sure if runtime check (execute $TMPE) is preferred.
>  >
>  >Let's just drop 1/11 then, and have the first patch cover the runtime of
>  >it. But don't do that from configure. Whatever fs is hosting configure
>  >is less interesting. Maybe that doesn't support fallocate, but whatever
>  >you end up running on does. Or vice versa.
>  >
>  >> Any how, I'll resend the 1,2,3,4,11 with --cover-letter as you commented.
>  > 
>  >Thanks!

Applied, thanks.

-- 
Jens Axboe



      parent reply	other threads:[~2017-05-24  2:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 18:43 [PATCH 0/2] configure kusumi.tomohiro
2017-05-23 18:43 ` [PATCH 1/2] configure: Use single square brackets (POSIX) kusumi.tomohiro
2017-05-23 18:43 ` [PATCH 2/2] configure: Add print_config() for "<config>... <yes|no>" outputs kusumi.tomohiro
2017-05-24  2:01 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170524020114.GA26621@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=kusumi.tomohiro@gmail.com \
    --cc=tkusumi@tuxera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.