diff for duplicates of <20170524020743.GH8158@eros> diff --git a/a/1.txt b/N1/1.txt index c218bbb..d12462c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -28,7 +28,7 @@ camel case in them still). > + unsigned int actual_max_clk; > > /* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */ -> if (sm750_get_chip_type() = SM750LE) +> if (sm750_get_chip_type() == SM750LE) > @@ -75,7 +75,7 @@ static void set_chip_clock(unsigned int frequency) > * Return value of sm750_calc_pll_value gives the actual > * possible clock. @@ -77,8 +77,8 @@ camel case in them still). > * the system might hang when sw accesses the memory. > * The memory should be resetted after changing the MXCLK. > */ -> - if (pInitParam->resetMemory = 1) { -> + if (init_param->resetMemory = 1) { +> - if (pInitParam->resetMemory == 1) { +> + if (init_param->resetMemory == 1) { > reg = peek32(MISC_CTRL); > reg &= ~MISC_CTRL_LOCALMEM_RESET; > poke32(MISC_CTRL, reg); @@ -86,13 +86,13 @@ camel case in them still). > poke32(MISC_CTRL, reg); > } > -> - if (pInitParam->setAllEngOff = 1) { -> + if (init_param->setAllEngOff = 1) { +> - if (pInitParam->setAllEngOff == 1) { +> + if (init_param->setAllEngOff == 1) { This would be nicer like this; -- if (pInitParam->setAllEngOff = 1) { -+ if (init_param->set_all_eng_off = 1) { +- if (pInitParam->setAllEngOff == 1) { ++ if (init_param->set_all_eng_off == 1) { Good luck, Tobin. diff --git a/a/content_digest b/N1/content_digest index 7c8a857..7273162 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01495544859-2639-1-git-send-email-richaj@cdac.in\0" "From\0Tobin C. Harding <me@tobin.cc>\0" "Subject\0Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables\0" - "Date\0Wed, 24 May 2017 02:07:43 +0000\0" + "Date\0Wed, 24 May 2017 12:07:43 +1000\0" "To\0Richa Jha <richaj@cdac.in>\0" "Cc\0gregkh@linuxfoundation.org" devel@driverdev.osuosl.org @@ -41,7 +41,7 @@ "> +\tunsigned int actual_max_clk;\n" "> \n" "> \t/* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */\n" - "> \tif (sm750_get_chip_type() = SM750LE)\n" + "> \tif (sm750_get_chip_type() == SM750LE)\n" "> @@ -75,7 +75,7 @@ static void set_chip_clock(unsigned int frequency)\n" "> \t\t * Return value of sm750_calc_pll_value gives the actual\n" "> \t\t * possible clock.\n" @@ -90,8 +90,8 @@ "> \t * the system might hang when sw accesses the memory.\n" "> \t * The memory should be resetted after changing the MXCLK.\n" "> \t */\n" - "> -\tif (pInitParam->resetMemory = 1) {\n" - "> +\tif (init_param->resetMemory = 1) {\n" + "> -\tif (pInitParam->resetMemory == 1) {\n" + "> +\tif (init_param->resetMemory == 1) {\n" "> \t\treg = peek32(MISC_CTRL);\n" "> \t\treg &= ~MISC_CTRL_LOCALMEM_RESET;\n" "> \t\tpoke32(MISC_CTRL, reg);\n" @@ -99,15 +99,15 @@ "> \t\tpoke32(MISC_CTRL, reg);\n" "> \t}\n" "> \n" - "> -\tif (pInitParam->setAllEngOff = 1) {\n" - "> +\tif (init_param->setAllEngOff = 1) {\n" + "> -\tif (pInitParam->setAllEngOff == 1) {\n" + "> +\tif (init_param->setAllEngOff == 1) {\n" "\n" "This would be nicer like this;\n" "\n" - "-\tif (pInitParam->setAllEngOff = 1) {\n" - "+\tif (init_param->set_all_eng_off = 1) {\n" + "-\tif (pInitParam->setAllEngOff == 1) {\n" + "+\tif (init_param->set_all_eng_off == 1) {\n" "\n" "Good luck,\n" Tobin. -aa716b394e55b0769b8f726f77cdc5f83fd8d52a36a733a8d5a157cc0c7af1f1 +381ee39349fd11b0f2b81af5d1115cc365fbefe1df397d26df4313c411c2df71
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.