From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
<patches@opensource.wolfsonmicro.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [mfd] question about potential null pointer dereference
Date: Wed, 24 May 2017 09:09:51 +0100 [thread overview]
Message-ID: <20170524080951.GO1594@localhost.localdomain> (raw)
In-Reply-To: <20170524072258.7qnnnrdodjwc55lk@dell>
On Wed, May 24, 2017 at 08:22:58AM +0100, Lee Jones wrote:
> On Tue, 23 May 2017, Gustavo A. R. Silva wrote:
> > The issue here is that there is a potential NULL pointer dereference at line
> > 37, in case function of_match_device() returns NULL.
> >
> > Maybe a patch like the following could be applied in order to avoid any
> > chance of a NULL pointer dereference:
>
> I do not believe it's possible for of_match_device() to return NULL in
> this case.
>
> However, if you wanted to submit a patch checking for it, it would not
> be rejected.
Personally I would prefer to have a NULL pointer check in there.
Thanks,
Charles
next prev parent reply other threads:[~2017-05-24 8:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 21:33 [mfd] question about potential null pointer dereference Gustavo A. R. Silva
2017-05-24 7:22 ` Lee Jones
2017-05-24 8:09 ` Charles Keepax [this message]
2017-05-24 8:19 ` Gustavo A. R. Silva
2017-05-24 8:27 ` [PATCH] mfd: add null check before " Gustavo A. R. Silva
2017-05-24 8:41 ` Charles Keepax
2017-05-24 8:43 ` Lee Jones
2017-05-24 8:50 ` Gustavo A. R. Silva
2017-05-24 9:18 ` [PATCH v2] mfd: wm831x: " Gustavo A. R. Silva
2017-05-24 10:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524080951.GO1594@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=garsilva@embeddedor.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.