All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <jroedel@suse.de>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: 'David Woodhouse' <dwmw2@infradead.org>,
	'Joerg Roedel' <joro@8bytes.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Daniel Drake <drake@endlessm.com>, Samuel Sieb <samuel@sieb.net>
Subject: Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs
Date: Wed, 24 May 2017 10:44:50 +0200	[thread overview]
Message-ID: <20170524084450.GB12353@suse.de> (raw)
In-Reply-To: <BN6PR12MB1652A0F240C19F2CF3304300F7F90@BN6PR12MB1652.namprd12.prod.outlook.com>

Hi Alexander,

On Tue, May 23, 2017 at 07:54:12PM +0000, Deucher, Alexander wrote:
> I finally got an answer from the hw team and we validated ATS on
> stoney as well so in theory this patch shouldn’t actually be needed.
> I think we may actually be papering over some other issue.  The
> following patch seems to also fix this issue (and other issues):
> https://www.spinics.net/lists/stable/msg172631.html

Yeah, but it still looks to me like that the hardware got into some
weird state with the storm of ATS invalidations sent to it.

The Completion-Wait loop timeouts seen in the original bug report
indicate that the IOMMU is waiting for a response that never comes. And
this is probably the ATS flush completion response from the GPU, as
disabling ATS on the GPU makes the issue disappear.

Regards,

	Joerg

  reply	other threads:[~2017-05-24  8:44 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 14:32 [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Joerg Roedel
2017-04-07 16:46 ` Deucher, Alexander
2017-04-07 16:46   ` Deucher, Alexander
2017-05-04 10:21   ` David Woodhouse
2017-05-04 14:41     ` Deucher, Alexander
2017-05-04 14:41       ` Deucher, Alexander
2017-05-23 19:54     ` Deucher, Alexander
2017-05-23 19:54       ` Deucher, Alexander
2017-05-24  8:44       ` Joerg Roedel [this message]
2017-05-24 10:38         ` David Woodhouse
2017-05-24 12:56         ` Deucher, Alexander
2017-05-24 12:56           ` Deucher, Alexander
2017-05-26  6:48           ` Samuel Sieb
2017-05-26 11:57         ` Deucher, Alexander
2017-05-26 11:57           ` Deucher, Alexander
2017-05-26 12:54           ` David Woodhouse
2017-05-26 15:59             ` Deucher, Alexander
2017-05-26 15:59               ` Deucher, Alexander
2017-04-08  7:41 ` Lukas Wunner
2017-04-20 12:11   ` Joerg Roedel
2017-06-15 17:12     ` Bjorn Helgaas
2017-06-15 14:04 ` Joerg Roedel
2017-06-15 17:01   ` Samuel Sieb
2017-06-15 18:13     ` Deucher, Alexander
2017-06-15 18:13       ` Deucher, Alexander
2017-06-15 19:15   ` Bjorn Helgaas
2017-06-16 16:29     ` Joerg Roedel
2017-07-10 16:53       ` Bjorn Helgaas
2017-07-11 11:49         ` Joerg Roedel
2017-07-11 19:08           ` Deucher, Alexander
2017-07-11 19:08             ` Deucher, Alexander
2017-07-13  2:56 ` Bjorn Helgaas
2017-08-29 20:02   ` Samuel Sieb
2017-08-29 20:49     ` Bjorn Helgaas
2017-08-30 11:44     ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170524084450.GB12353@suse.de \
    --to=jroedel@suse.de \
    --cc=Alexander.Deucher@amd.com \
    --cc=bhelgaas@google.com \
    --cc=drake@endlessm.com \
    --cc=dwmw2@infradead.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=samuel@sieb.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.