From: keith.busch@intel.com (Keith Busch)
Subject: Getting rid of nvme's pci watchdog timer?
Date: Wed, 24 May 2017 07:21:42 -0400 [thread overview]
Message-ID: <20170524112141.GA13742@localhost.localdomain> (raw)
In-Reply-To: <20170524094219.GB17483@lst.de>
On Wed, May 24, 2017@11:42:19AM +0200, Christoph Hellwig wrote:
> an idle controller all the time seems pretty useful to me. I don't
> really understand the need for the watchdog fully as it predates my
> involvement, but I vaguely remember discussion the issue with Keith
> a while ago, so he might be able to help.
This was originally added to the driver's health check kthread to
keep a pulse on the devices, but I think it's causing more harm than
good. The hotplug races are bad enough, and this power savings killer is
yet another reason to remove it. I'm in favor of removing the watchdog
timer and moving the status check to the timeout callback so we verify
health only when we have a reason to believe something is wrong.
prev parent reply other threads:[~2017-05-24 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 21:23 Getting rid of nvme's pci watchdog timer? Andy Lutomirski
2017-05-24 9:42 ` Christoph Hellwig
2017-05-24 11:21 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524112141.GA13742@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.