From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net-next 2/4] nfp: register ports as devlink ports
Date: Wed, 24 May 2017 14:35:14 +0200 [thread overview]
Message-ID: <20170524123514.GB1908@nanopsycho> (raw)
In-Reply-To: <20170523151247.8535-3-jakub.kicinski@netronome.com>
Tue, May 23, 2017 at 05:12:45PM CEST, jakub.kicinski@netronome.com wrote:
>Extend nfp_port to contain devlink_port structures. Register the
>ports to allow users inspecting device ports.
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>Reviewed-by: Simon Horman <simon.horman@netronome.com>
>---
[...]
>+void nfp_devlink_port_unregister(struct nfp_port *port)
>+{
>+ /* Due to unpleasant lock ordering we may see the port go away before
>+ * we have fully probed.
Could you elaborate on this a bit more please?
>+ */
>+ if (port->dl_port.registered)
>+ devlink_port_unregister(&port->dl_port);
>+}
next prev parent reply other threads:[~2017-05-24 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 15:12 [PATCH net-next 0/4] nfp: devlink port implementation Jakub Kicinski
2017-05-23 15:12 ` [PATCH net-next 1/4] nfp: add devlink support Jakub Kicinski
2017-05-23 15:12 ` [PATCH net-next 2/4] nfp: register ports as devlink ports Jakub Kicinski
2017-05-24 12:35 ` Jiri Pirko [this message]
2017-05-24 19:24 ` Jakub Kicinski
2017-05-25 8:20 ` Jiri Pirko
2017-05-23 15:12 ` [PATCH net-next 3/4] nfp: calculate total port lanes for split Jakub Kicinski
2017-05-23 15:12 ` [PATCH net-next 4/4] nfp: support port splitting via devlink Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524123514.GB1908@nanopsycho \
--to=jiri@resnulli.us \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.