From: Keith Busch <keith.busch@intel.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Jeffy Chen <jeffy.chen@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Krishna Dhulipala <krishnad@fb.com>,
Christoph Hellwig <hch@lst.de>, Wei Zhang <wzhang@fb.com>
Subject: Re: [PATCH] PCI: Make error code types consistent in pci_{read,write}_config_*
Date: Thu, 25 May 2017 02:50:16 -0400 [thread overview]
Message-ID: <20170525065015.GA25033@localhost.localdomain> (raw)
In-Reply-To: <20170523193655.GA144183@google.com>
On Tue, May 23, 2017 at 12:36:58PM -0700, Brian Norris wrote:
> Callers normally treat the config space accessors as returning PCBIOS_*
> error codes, not Linux error codes (or they don't look at them at all).
> We have pcibios_err_to_errno(), in case the error code needs translated.
>
> Fixes: 4b1038834739 ("PCI: Don't attempt config access to disconnected devices")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
That looks fine to me.
Reviewed-by: Keith Busch <keith.busch@intel.com>
next prev parent reply other threads:[~2017-05-25 6:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 6:58 [PATCH] PCI: rockchip: check link status when validating device Shawn Lin
2017-05-23 18:00 ` Brian Norris
2017-05-24 0:54 ` Shawn Lin
2017-05-24 1:00 ` Brian Norris
2017-05-24 1:14 ` Shawn Lin
2017-05-24 1:25 ` Brian Norris
2017-05-23 18:44 ` Brian Norris
2017-05-23 19:36 ` [PATCH] PCI: Make error code types consistent in pci_{read,write}_config_* Brian Norris
2017-05-23 19:36 ` Brian Norris
2017-05-25 6:50 ` Keith Busch [this message]
2017-05-26 21:40 ` Bjorn Helgaas
2017-05-26 21:40 ` Bjorn Helgaas
2017-05-23 19:44 ` [PATCH] PCI: rockchip: check link status when validating device Bjorn Helgaas
2017-05-24 1:04 ` Shawn Lin
2017-05-24 1:04 ` Shawn Lin
2017-05-24 1:15 ` Brian Norris
2017-05-24 21:33 ` Bjorn Helgaas
2017-05-24 21:43 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525065015.GA25033@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=hch@lst.de \
--cc=jeffy.chen@rock-chips.com \
--cc=krishnad@fb.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.