From: Stephen Hemminger <stephen@networkplumber.org>
To: Gregory Etelson <gregory@weka.io>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: Re: i40e igb_uio: reset pci on process exit
Date: Thu, 25 May 2017 11:42:42 -0700 [thread overview]
Message-ID: <20170525114242.3c6ac1b7@xeon-e3> (raw)
In-Reply-To: <106841857.Z7q1jSDIte@polaris>
On Wed, 24 May 2017 14:22:11 +0300
Gregory Etelson <gregory@weka.io> wrote:
>
> +static int
> +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> +{
> + int ret;
> + struct rte_uio_pci_dev *udev = info->priv;
> + struct pci_dev *dev = udev->pdev;
> + ret = __pci_reset_function(dev);
> + dev_info(&dev->dev, "pci_reset_function %s \n",
> + ret == 0 ? "succeded" : "failed");
> + return 0;
> +}
> +
> +
Patch in general looks ok, but:
* no Signed-off
* whitespace issues
* doesn't pass kernel coding style
* don't log on success, why log at all??
next prev parent reply other threads:[~2017-05-25 18:42 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 11:22 i40e igb_uio: reset pci on process exit Gregory Etelson
2017-05-25 18:42 ` Stephen Hemminger [this message]
2017-05-26 4:30 ` Gregory Etelson
2017-05-26 6:05 ` Shijith Thotton
2017-05-26 6:17 ` Gregory Etelson
2017-05-26 15:53 ` Stephen Hemminger
2017-05-26 16:14 ` Gregory Etelson
2017-05-29 9:48 ` Shijith Thotton
2017-05-29 10:01 ` Gregory Etelson
2017-05-29 11:01 ` Shijith Thotton
2017-05-29 11:21 ` Gregory Etelson
2017-05-31 11:09 ` [RFC PATCH] igb_uio: issue FLR during open and release of device file Shijith Thotton
2017-05-31 12:20 ` Ferruh Yigit
2017-05-31 15:30 ` Stephen Hemminger
2017-05-31 17:11 ` Ferruh Yigit
2017-06-01 11:35 ` Shijith Thotton
2017-06-01 11:14 ` Gregory Etelson
2017-06-04 7:22 ` Gregory Etelson
2017-06-05 2:29 ` Tan, Jianfeng
2017-06-05 5:57 ` Gregory Etelson
2017-05-31 15:29 ` Stephen Hemminger
2017-06-12 9:38 ` [PATCH] " Shijith Thotton
2017-07-05 23:42 ` Thomas Monjalon
2017-07-06 16:41 ` Ferruh Yigit
2017-07-06 17:27 ` Gregory Etelson
2017-07-07 10:03 ` Shijith Thotton
2017-07-07 10:16 ` Ferruh Yigit
2017-07-07 11:13 ` [PATCH v2] " Shijith Thotton
2017-07-07 15:10 ` Ferruh Yigit
2017-07-10 3:07 ` Gregory Etelson
2017-07-11 5:42 ` Gregory Etelson
2017-07-11 11:36 ` Gregory Etelson
2017-07-10 3:38 ` Tan, Jianfeng
2017-07-10 7:10 ` Shijith Thotton
2017-07-10 9:00 ` Tan, Jianfeng
2017-07-10 10:42 ` Shijith Thotton
2017-07-12 3:37 ` Tan, Jianfeng
2017-07-12 3:40 ` Tan, Jianfeng
2017-07-19 13:32 ` Ferruh Yigit
2017-07-19 16:19 ` Gregory Etelson
2017-07-20 22:36 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2017-07-16 4:22 [SPDK] " Gregory Etelson
2017-07-16 4:22 ` Gregory Etelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525114242.3c6ac1b7@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gregory@weka.io \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.