From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424127AbdEYNXz (ORCPT ); Thu, 25 May 2017 09:23:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41448 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933110AbdEYNXv (ORCPT ); Thu, 25 May 2017 09:23:51 -0400 Date: Thu, 25 May 2017 15:23:39 +0200 From: Greg Kroah-Hartman To: Mika Westerberg Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , Lukas Wunner , Amir Levy , Andy Lutomirski , Mario.Limonciello@dell.com, Jared.Dominguez@dell.com, Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/24] thunderbolt: Introduce thunderbolt bus and connection manager Message-ID: <20170525132339.GH16244@kroah.com> References: <20170518143914.60902-1-mika.westerberg@linux.intel.com> <20170518143914.60902-7-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170518143914.60902-7-mika.westerberg@linux.intel.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 05:38:56PM +0300, Mika Westerberg wrote: > Thunderbolt fabric consists of one or more switches. This fabric is > called domain and it is controlled by an entity called connection > manager. The connection manager can be either internal (driven by a > firmware running on the host controller) or external (software driver). > This driver currently implements support for the latter. > > In order to manage switches and their properties more easily we model > this domain structure as a Linux bus. Each host controller adds a domain > device to this bus, and these devices are named as domainN where N > stands for index or id of the current domain. > > We then abstract connection manager specific operations into a new > structure tb_cm_ops and convert the existing tb.c to fill those > accordingly. This makes it easier to add support for the internal > connection manager in subsequent patches. > > Signed-off-by: Mika Westerberg > Reviewed-by: Yehezkel Bernat > Reviewed-by: Michael Jamet > --- > drivers/thunderbolt/Makefile | 2 +- > drivers/thunderbolt/domain.c | 230 +++++++++++++++++++++++++++++++++++++++ > drivers/thunderbolt/nhi.c | 31 ++++-- > drivers/thunderbolt/tb.c | 156 ++++++++++++-------------- > drivers/thunderbolt/tb.h | 70 +++++++++--- > drivers/thunderbolt/tunnel_pci.c | 9 +- > 6 files changed, 377 insertions(+), 121 deletions(-) > create mode 100644 drivers/thunderbolt/domain.c > > diff --git a/drivers/thunderbolt/Makefile b/drivers/thunderbolt/Makefile > index 5d1053cdfa54..e276a9a62261 100644 > --- a/drivers/thunderbolt/Makefile > +++ b/drivers/thunderbolt/Makefile > @@ -1,3 +1,3 @@ > obj-${CONFIG_THUNDERBOLT} := thunderbolt.o > thunderbolt-objs := nhi.o ctl.o tb.o switch.o cap.o path.o tunnel_pci.o eeprom.o > - > +thunderbolt-objs += domain.o > diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c > new file mode 100644 > index 000000000000..b5bfca95415d > --- /dev/null > +++ b/drivers/thunderbolt/domain.c > @@ -0,0 +1,230 @@ > +/* > + * Thunderbolt bus support > + * > + * Copyright (C) 2017, Intel Corporation > + * Author: Mika Westerberg > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include > +#include > +#include > +#include > + > +#include "tb.h" > + > +static DEFINE_IDA(tb_domain_ida); You forgot to clean this up in your module exit code with a call to ida_destroy(&tb_domain_ida); Yeah, it's not obvious, I've made the same mistake before :) Other than that minor thing, the bus logic looks good, nice job. thanks, greg k-h