From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966650AbdEYOme (ORCPT ); Thu, 25 May 2017 10:42:34 -0400 Received: from mga14.intel.com ([192.55.52.115]:6111 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966584AbdEYOmd (ORCPT ); Thu, 25 May 2017 10:42:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,391,1491289200"; d="scan'208";a="1174252449" Date: Thu, 25 May 2017 17:42:28 +0300 From: Mika Westerberg To: Greg Kroah-Hartman Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , Lukas Wunner , Amir Levy , Andy Lutomirski , Mario.Limonciello@dell.com, Jared.Dominguez@dell.com, Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/24] thunderbolt: Introduce thunderbolt bus and connection manager Message-ID: <20170525144228.GV8541@lahna.fi.intel.com> References: <20170518143914.60902-1-mika.westerberg@linux.intel.com> <20170518143914.60902-7-mika.westerberg@linux.intel.com> <20170525132339.GH16244@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170525132339.GH16244@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 03:23:39PM +0200, Greg Kroah-Hartman wrote: > On Thu, May 18, 2017 at 05:38:56PM +0300, Mika Westerberg wrote: > > Thunderbolt fabric consists of one or more switches. This fabric is > > called domain and it is controlled by an entity called connection > > manager. The connection manager can be either internal (driven by a > > firmware running on the host controller) or external (software driver). > > This driver currently implements support for the latter. > > > > In order to manage switches and their properties more easily we model > > this domain structure as a Linux bus. Each host controller adds a domain > > device to this bus, and these devices are named as domainN where N > > stands for index or id of the current domain. > > > > We then abstract connection manager specific operations into a new > > structure tb_cm_ops and convert the existing tb.c to fill those > > accordingly. This makes it easier to add support for the internal > > connection manager in subsequent patches. > > > > Signed-off-by: Mika Westerberg > > Reviewed-by: Yehezkel Bernat > > Reviewed-by: Michael Jamet > > --- > > drivers/thunderbolt/Makefile | 2 +- > > drivers/thunderbolt/domain.c | 230 +++++++++++++++++++++++++++++++++++++++ > > drivers/thunderbolt/nhi.c | 31 ++++-- > > drivers/thunderbolt/tb.c | 156 ++++++++++++-------------- > > drivers/thunderbolt/tb.h | 70 +++++++++--- > > drivers/thunderbolt/tunnel_pci.c | 9 +- > > 6 files changed, 377 insertions(+), 121 deletions(-) > > create mode 100644 drivers/thunderbolt/domain.c > > > > diff --git a/drivers/thunderbolt/Makefile b/drivers/thunderbolt/Makefile > > index 5d1053cdfa54..e276a9a62261 100644 > > --- a/drivers/thunderbolt/Makefile > > +++ b/drivers/thunderbolt/Makefile > > @@ -1,3 +1,3 @@ > > obj-${CONFIG_THUNDERBOLT} := thunderbolt.o > > thunderbolt-objs := nhi.o ctl.o tb.o switch.o cap.o path.o tunnel_pci.o eeprom.o > > - > > +thunderbolt-objs += domain.o > > diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c > > new file mode 100644 > > index 000000000000..b5bfca95415d > > --- /dev/null > > +++ b/drivers/thunderbolt/domain.c > > @@ -0,0 +1,230 @@ > > +/* > > + * Thunderbolt bus support > > + * > > + * Copyright (C) 2017, Intel Corporation > > + * Author: Mika Westerberg > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > + > > +#include "tb.h" > > + > > +static DEFINE_IDA(tb_domain_ida); > > You forgot to clean this up in your module exit code with a call to > ida_destroy(&tb_domain_ida); Ah, I see. OK, I'll add that missing call to tb_domain_exit(). > Yeah, it's not obvious, I've made the same mistake before :) > > Other than that minor thing, the bus logic looks good, nice job. Thanks :-)