From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Thu, 25 May 2017 18:58:44 +0200 Subject: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings In-Reply-To: <20170522120935.4119-2-laurentiu.tudor@nxp.com> References: <20170522120935.4119-1-laurentiu.tudor@nxp.com> <20170522120935.4119-2-laurentiu.tudor@nxp.com> Message-ID: <20170525165844.GA8812@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor at nxp.com wrote: > From: Laurentiu Tudor Your subject line is very odd, please use the 'v2' marking properly... > > Remove several unneeded #includes, forward > declarations and fix several issues reported > by checkpatch.pl --strict, such as: > - kfree(NULL) is safe and check is not required > - macro argument reuse may cause possible side effects > - enclose macro params in parens to avoid precedence issues > - coding style These, as always, need to be broken up into one-patch-per-type-of-thing, you have been in the staging tree long enough to know this :( Please do this first, then we can consider the rest of the series... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942826AbdEYQ65 (ORCPT ); Thu, 25 May 2017 12:58:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38336 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756340AbdEYQ64 (ORCPT ); Thu, 25 May 2017 12:58:56 -0400 Date: Thu, 25 May 2017 18:58:44 +0200 From: Greg KH To: laurentiu.tudor@nxp.com Cc: stuyoder@gmail.com, devel@driverdev.osuosl.org, arnd@arndb.de, roy.pledge@nxp.com, linux-kernel@vger.kernel.org, agraf@suse.de, catalin.horghidan@nxp.com, ioana.ciornei@nxp.com, leoyang.li@nxp.com, bharat.bhushan@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings Message-ID: <20170525165844.GA8812@kroah.com> References: <20170522120935.4119-1-laurentiu.tudor@nxp.com> <20170522120935.4119-2-laurentiu.tudor@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170522120935.4119-2-laurentiu.tudor@nxp.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@nxp.com wrote: > From: Laurentiu Tudor Your subject line is very odd, please use the 'v2' marking properly... > > Remove several unneeded #includes, forward > declarations and fix several issues reported > by checkpatch.pl --strict, such as: > - kfree(NULL) is safe and check is not required > - macro argument reuse may cause possible side effects > - enclose macro params in parens to avoid precedence issues > - coding style These, as always, need to be broken up into one-patch-per-type-of-thing, you have been in the staging tree long enough to know this :( Please do this first, then we can consider the rest of the series... thanks, greg k-h