All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] RFC: arm: eBPF JIT compiler
Date: Thu, 25 May 2017 19:00:51 +0200	[thread overview]
Message-ID: <20170525170051.GC18357@lunn.ch> (raw)
In-Reply-To: <CAHgaXdKn4J==r_22T3N_7O5oESd8xwL6L+Ot8nT9bGCsSjAkHw@mail.gmail.com>

On Thu, May 25, 2017 at 02:01:36AM +0530, Shubham Bansal wrote:
> Hi Andrew,
> 
> I am attaching the latest patch which should work on ARMv5 , ARMv6 and ARMv7.
> 
> Please test on your machines. Apologies for the last patch. This patch
> should work though.

andrew at shuttle:~/linux$ make -s -j 16
arch/arm/net/bpf_jit_32.c:1755:12: warning: ???validate_code??? defined but not used [-Wunused-function]
 static int validate_code(struct jit_ctx *ctx)
            ^~~~~~~~~~~~~
arch/arm/net/bpf_jit_32.c:1724:12: warning: ???build_body??? defined but not used [-Wunused-function]
 static int build_body(struct jit_ctx *ctx)
            ^~~~~~~~~~
arch/arm/net/bpf_jit_32.c:1122:13: warning: ???build_epilogue??? defined but not used [-Wunused-function]
 static void build_epilogue(struct jit_ctx *ctx)
             ^~~~~~~~~~~~~~
arch/arm/net/bpf_jit_32.c:1049:13: warning: ???build_prologue??? defined but not used [-Wunused-function]
 static void build_prologue(struct jit_ctx *ctx)
             ^~~~~~~~~~~~~~
arch/arm/net/bpf_jit_32.c:174:13: warning: ???jit_fill_hole??? defined but not used [-Wunused-function]
 static void jit_fill_hole(void *area, unsigned int size)
             ^~~~~~~~~~~~~

I _think_ this is because CONFIG_CPU_LITTLE_ENDIAN is not set. But it
is a little endian machine/configuration. ARM does not seem to use
CONFIG_CPU_LITTLE_ENDIAN, it just has CPU_BIG_ENDIAN.

	  Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Shubham Bansal <illusionist.neo@gmail.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] RFC: arm: eBPF JIT compiler
Date: Thu, 25 May 2017 19:00:51 +0200	[thread overview]
Message-ID: <20170525170051.GC18357@lunn.ch> (raw)
In-Reply-To: <CAHgaXdKn4J==r_22T3N_7O5oESd8xwL6L+Ot8nT9bGCsSjAkHw@mail.gmail.com>

On Thu, May 25, 2017 at 02:01:36AM +0530, Shubham Bansal wrote:
> Hi Andrew,
> 
> I am attaching the latest patch which should work on ARMv5 , ARMv6 and ARMv7.
> 
> Please test on your machines. Apologies for the last patch. This patch
> should work though.

andrew@shuttle:~/linux$ make -s -j 16
arch/arm/net/bpf_jit_32.c:1755:12: warning: ‘validate_code’ defined but not used [-Wunused-function]
 static int validate_code(struct jit_ctx *ctx)
            ^~~~~~~~~~~~~
arch/arm/net/bpf_jit_32.c:1724:12: warning: ‘build_body’ defined but not used [-Wunused-function]
 static int build_body(struct jit_ctx *ctx)
            ^~~~~~~~~~
arch/arm/net/bpf_jit_32.c:1122:13: warning: ‘build_epilogue’ defined but not used [-Wunused-function]
 static void build_epilogue(struct jit_ctx *ctx)
             ^~~~~~~~~~~~~~
arch/arm/net/bpf_jit_32.c:1049:13: warning: ‘build_prologue’ defined but not used [-Wunused-function]
 static void build_prologue(struct jit_ctx *ctx)
             ^~~~~~~~~~~~~~
arch/arm/net/bpf_jit_32.c:174:13: warning: ‘jit_fill_hole’ defined but not used [-Wunused-function]
 static void jit_fill_hole(void *area, unsigned int size)
             ^~~~~~~~~~~~~

I _think_ this is because CONFIG_CPU_LITTLE_ENDIAN is not set. But it
is a little endian machine/configuration. ARM does not seem to use
CONFIG_CPU_LITTLE_ENDIAN, it just has CPU_BIG_ENDIAN.

	  Andrew

  parent reply	other threads:[~2017-05-25 17:00 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 18:33 [PATCH] RFC: arm: eBPF JIT compiler Shubham Bansal
2017-05-23 18:33 ` Shubham Bansal
2017-05-23 19:00 ` Russell King - ARM Linux
2017-05-23 19:00   ` Russell King - ARM Linux
2017-05-23 19:13   ` Shubham Bansal
2017-05-23 19:13     ` Shubham Bansal
2017-05-23 20:34 ` Andrew Lunn
2017-05-23 20:34   ` Andrew Lunn
2017-05-23 20:46 ` Andrew Lunn
2017-05-23 20:46   ` Andrew Lunn
2017-05-23 20:54   ` Shubham Bansal
2017-05-23 20:54     ` Shubham Bansal
2017-05-23 23:25     ` Andrew Lunn
2017-05-23 23:25       ` Andrew Lunn
2017-05-24 20:31       ` Shubham Bansal
2017-05-25 16:12         ` Shubham Bansal
2017-05-25 16:12           ` Shubham Bansal
2017-05-25 17:00         ` Andrew Lunn [this message]
2017-05-25 17:00           ` Andrew Lunn
2017-05-25 17:22           ` Andrew Lunn
2017-05-25 17:22             ` Andrew Lunn
     [not found]             ` <CAHgaXd+CVrDEA=E2=23Qp6wk50=dBnFS6TiCtvphTBMjUywrGg@mail.gmail.com>
2017-05-25 18:28               ` Andrew Lunn
2017-05-25 18:28                 ` Andrew Lunn
2017-05-25 18:35                 ` Shubham Bansal
2017-05-25 18:35                   ` Shubham Bansal
2017-05-25 18:48                   ` Andrew Lunn
2017-05-25 18:48                     ` Andrew Lunn
2017-05-25 19:09                     ` Shubham Bansal
2017-05-25 19:09                       ` Shubham Bansal
2017-05-25 19:44                       ` Florian Fainelli
2017-05-25 19:44                         ` Florian Fainelli
2017-05-25 20:08                         ` Shubham Bansal
2017-05-25 20:08                           ` Shubham Bansal
2017-05-25 20:59                           ` Kees Cook
2017-05-25 20:59                             ` Kees Cook
2017-05-25 21:12                           ` Florian Fainelli
2017-05-25 21:12                             ` Florian Fainelli
2017-05-25 22:10                         ` Russell King - ARM Linux
2017-05-25 22:10                           ` Russell King - ARM Linux
2017-05-23 21:17   ` Shubham Bansal
2017-05-23 21:17     ` Shubham Bansal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170525170051.GC18357@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.