From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: KT Liao <kt.liao@emc.com.tw>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
phoenix@emc.com.tw
Subject: Re: [PATCH] Input: elan_i2c - Clean INT stats in FW updating for old Elan touchpad
Date: Thu, 25 May 2017 10:09:28 -0700 [thread overview]
Message-ID: <20170525170928.GA29859@dtor-ws> (raw)
In-Reply-To: <1495619019-28981-1-git-send-email-kt.liao@emc.com.tw>
On Wed, May 24, 2017 at 05:43:39PM +0800, KT Liao wrote:
> Some old touchapd FWs have interrupt issue after FW updating.
> Use reading 34 bytes before IC reset command to clean INT stauts
> The modification has been tested in some chromebook system
> It should not affect general touchpad in Linux system.
>
> Signed-off-by: KT Liao <kt.liao@emc.com.tw>
Applied, thank you.
> ---
> drivers/input/mouse/elan_i2c_i2c.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_i2c.c b/drivers/input/mouse/elan_i2c_i2c.c
> index 3be75c6e..842f852 100644
> --- a/drivers/input/mouse/elan_i2c_i2c.c
> +++ b/drivers/input/mouse/elan_i2c_i2c.c
> @@ -612,7 +612,14 @@ static int elan_i2c_finish_fw_update(struct i2c_client *client,
> long ret;
> int error;
> int len;
> - u8 buffer[ETP_I2C_INF_LENGTH];
> + u8 buffer[ETP_I2C_REPORT_LEN];
> +
> + len = i2c_master_recv(client, buffer, ETP_I2C_REPORT_LEN);
> + if (len != ETP_I2C_REPORT_LEN) {
> + error = len < 0 ? len : -EIO;
> + dev_warn(dev, "failed to read I2C data after FW WDT reset: %d (%d)\n",
> + error, len);
> + }
>
> reinit_completion(completion);
> enable_irq(client->irq);
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2017-05-25 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 9:43 [PATCH] Input: elan_i2c - Clean INT stats in FW updating for old Elan touchpad KT Liao
2017-05-25 17:09 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525170928.GA29859@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=kt.liao@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phoenix@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.