From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2] kvm-xfstests, gce-xfstests: improve recommended kernel config
Date: Thu, 25 May 2017 11:43:24 -0700 [thread overview]
Message-ID: <20170525184324.GA81861@gmail.com> (raw)
In-Reply-To: <20170525172411.tbi56oe27oz6rnuj@thunk.org>
On Thu, May 25, 2017 at 01:24:11PM -0400, Theodore Ts'o wrote:
> On Tue, May 23, 2017 at 10:45:57AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Trim more unneeded features from the recommended kernel config, then
> > enable some more relatively lightweight debugging options.
> >
> > For now, just update the latest x86_64 config. But if people are okay
> > with these changes I'll update some of the other configs too.
> >
> > Tested with both kvm-xfstests and gce-xfstests.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> This looks good to me. Would you mind sending a patch which updates
> the rest of the configs similarly, so we can update all of the configs
> at once?
>
> As an aside, I *do* use the HW_RANDOM_VIRTIO from time to time (that's
> why it was enabled in the config), and in fact kvm-xfstests is wired
> up to supply the virtio random number generator by default (since it
> doesn't really cost much):
>
> if test -z "$NO_VIRTIO_RNG" ; then
> VIRTIO_RNG="-object rng-random,filename=/dev/urandom,id=rng0 \
> -device virtio-rng-pci,rng=rng0"
> fi
>
> But that's for my kernel RNG testing, and it's fair to say that that
> most users of kvm-xfstests won't need it.
>
Yes I'll do that. I'll probably leave HW_RANDOM_VIRTIO on, given that the
virtio-rng-pci device is emulated by default, and the kernel config ought to
support the default emulated hardware. (Or else we should turn the
virtio-rng-pci device off by default.)
Eric
prev parent reply other threads:[~2017-05-25 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 17:45 [PATCH v2] kvm-xfstests, gce-xfstests: improve recommended kernel config Eric Biggers
2017-05-25 17:24 ` Theodore Ts'o
2017-05-25 18:43 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525184324.GA81861@gmail.com \
--to=ebiggers3@gmail.com \
--cc=amir73il@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.