From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support
Date: Thu, 25 May 2017 22:54:55 +0200 [thread overview]
Message-ID: <20170525205455.GB9501@mai> (raw)
In-Reply-To: <1494660575-30465-2-git-send-email-aisheng.dong@nxp.com>
On Sat, May 13, 2017 at 03:29:35PM +0800, Dong Aisheng wrote:
> IMX Timer/PWM Module (TPM) supports both timer and pwm function while
> this patch only adds the timer support. PWM would be added later.
>
> The TPM counter, compare and capture registers are clocked by an
> asynchronous clock that can remain enabled in low power modes.
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Bai Ping <ping.bai@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
[ ... ]
> + val = __raw_readl(timer_base + TPM_C0SC);
> + val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> + __raw_writel(val, timer_base + TPM_C0SC);
Hi Dong,
why are you using __raw_write/__raw_read instead of regular readl/writel?
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tglx@linutronix.de,
shawnguo@kernel.org, ping.bai@nxp.com, anson.huang@nxp.com,
dongas86@gmail.com, kernel@pengutronix.de, arnd@arndb.de
Subject: Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support
Date: Thu, 25 May 2017 22:54:55 +0200 [thread overview]
Message-ID: <20170525205455.GB9501@mai> (raw)
In-Reply-To: <1494660575-30465-2-git-send-email-aisheng.dong@nxp.com>
On Sat, May 13, 2017 at 03:29:35PM +0800, Dong Aisheng wrote:
> IMX Timer/PWM Module (TPM) supports both timer and pwm function while
> this patch only adds the timer support. PWM would be added later.
>
> The TPM counter, compare and capture registers are clocked by an
> asynchronous clock that can remain enabled in low power modes.
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Bai Ping <ping.bai@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
[ ... ]
> + val = __raw_readl(timer_base + TPM_C0SC);
> + val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> + __raw_writel(val, timer_base + TPM_C0SC);
Hi Dong,
why are you using __raw_write/__raw_read instead of regular readl/writel?
next prev parent reply other threads:[~2017-05-25 20:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 7:29 [PATCH 1/2] dt-bindings: timer: add nxp tpm timer binding doc Dong Aisheng
2017-05-13 7:29 ` Dong Aisheng
2017-05-13 7:29 ` Dong Aisheng
2017-05-13 7:29 ` [PATCH 2/2] timer: imx-tpm: add imx tpm timer support Dong Aisheng
2017-05-13 7:29 ` Dong Aisheng
2017-05-25 20:54 ` Daniel Lezcano [this message]
2017-05-25 20:54 ` Daniel Lezcano
2017-05-31 6:36 ` Dong Aisheng
2017-05-31 6:36 ` Dong Aisheng
2017-05-25 21:02 ` Arnd Bergmann
2017-05-25 21:02 ` Arnd Bergmann
2017-05-31 6:34 ` Dong Aisheng
2017-05-31 6:34 ` Dong Aisheng
2017-05-19 1:25 ` [PATCH 1/2] dt-bindings: timer: add nxp tpm timer binding doc Rob Herring
2017-05-19 1:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525205455.GB9501@mai \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.