From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Wei Wang <wei.w.wang@intel.com>,
virtio-dev@lists.oasis-open.org, stefanha@gmail.com,
qemu-devel@nongnu.org, jan.scheurich@ericsson.com,
marcandre.lureau@gmail.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH RFC] virtio-net: enable configurable tx queue size
Date: Thu, 25 May 2017 21:04:39 +0300 [thread overview]
Message-ID: <20170525210048-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <2fb56ab7-99c6-ac30-de60-a747438416b8@redhat.com>
On Thu, May 25, 2017 at 08:13:31PM +0800, Jason Wang wrote:
> >
> > The point of using the config field here is, when tomorrow's device is
> > released with a requirement for the driver
> > to use max_chain_size=1022 (not today's 1023), today's driver will
> > naturally support tomorrow's device without
> > any modification, since it reads the max_chain_size from the config
> > field which is filled by the device (either today's
> > device or tomorrow's device with different values).
>
> I'm not saying anything wrong with the config filed you introduced. But you
> should answer the following question:
>
> Is it useful to support more than 1024? If yes, why? If not, introduce a
> VIRTIO_F_SG_1024 is more than enough I think.
>
> Thanks
I think it's useful to limit it below queue size too.
--
MST
prev parent reply other threads:[~2017-05-25 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 2:32 [Qemu-devel] [PATCH RFC] virtio-net: enable configurable tx queue size Wei Wang
2017-05-19 20:42 ` Michael S. Tsirkin
2017-05-22 11:52 ` [Qemu-devel] [virtio-dev] " Wei Wang
2017-05-23 2:04 ` Jason Wang
2017-05-23 5:15 ` Wei Wang
2017-05-23 6:24 ` Jason Wang
2017-05-23 10:36 ` Wei Wang
2017-05-24 3:19 ` Jason Wang
2017-05-24 8:18 ` Wei Wang
2017-05-25 7:49 ` Jason Wang
2017-05-25 11:50 ` Wei Wang
2017-05-25 12:13 ` [Qemu-devel] [virtio-dev] " Jason Wang
2017-05-25 18:04 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525210048-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jan.scheurich@ericsson.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.