From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Du, Changbin" Subject: Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected Date: Fri, 26 May 2017 18:27:08 +0800 Message-ID: <20170526102708.GA7075@intel.com> References: <1495615839-20797-1-git-send-email-changbin.du@intel.com> <87efvetrl1.fsf@intel.com> <20170525060944.GA25623@intel.com> <87mva0lz1c.fsf@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0004386872==" Return-path: In-Reply-To: <87mva0lz1c.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com, intel-gvt-dev@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0004386872== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI" Content-Disposition: inline --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 26, 2017 at 12:58:55PM +0300, Jani Nikula wrote: > On Thu, 25 May 2017, "Du, Changbin" wrote: > >> Note: > >> select should be used with care. select will force > >> a symbol to a value without visiting the dependencies. > >> By abusing select you are able to select a symbol FOO even > >> if FOO depends on BAR that is not set. > >> In general use select only for non-visible symbols > >> (no prompts anywhere) and for symbols with no dependencies. > >> That will limit the usefulness but on the other hand avoid > >> the illegal configurations all over. > >>=20 > > Yes, we should always be carefull with 'select' and should not use it if > > possible. So here I must create a 'menu' to ensure its safety. >=20 > I'm trying to say, why do you make DRM_I915_GVT visible in menuconfig at > all when you can't actually change it in menuconfig? >=20 ok, that is to info the user that GVT is enabled, since DRM_I915_GVT apply = to seperated i915 module. I saw similar behaviour in some driver, but cannot r= ecall its name now... > BR, > Jani. >=20 >=20 >=20 > > > >> BR, > >> Jani. > >>=20 > >> > Choose this option if you want to enable Intel GVT-g graphics > >> > virtualization technology host support with integrated graphics. > >> > With GVT-g, it's possible to have one integrated graphics > >> > @@ -116,13 +119,14 @@ config DRM_I915_GVT > >> > =20 > >> > config DRM_I915_GVT_KVMGT > >> > tristate "Enable KVM/VFIO support for Intel GVT-g" > >> > - depends on DRM_I915_GVT > >> > + select DRM_I915_GVT > >> > depends on KVM > >> > depends on VFIO_MDEV && VFIO_MDEV_DEVICE > >> > default n > >> > help > >> > Choose this option if you want to enable KVMGT support for > >> > Intel GVT-g. > >> > +endmenu > >> > =20 > >> > menu "drm/i915 Debugging" > >> > depends on DRM_I915 > >>=20 > >> --=20 > >> Jani Nikula, Intel Open Source Technology Center > >> _______________________________________________ > >> intel-gvt-dev mailing list > >> intel-gvt-dev@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev >=20 > --=20 > Jani Nikula, Intel Open Source Technology Center --=20 Thanks, Changbin Du --+HP7ph2BbKc20aGI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJZKAL8AAoJEAanuZwLnPNU2dkH/A8/uHSIuBTrUcPZyDyiM0bb tjaQJM6DtFpq5Mfip4MkZKANZSgYq1lYkijSLVByO04MDrki2hH4boc2in74LEak WrVeGD9rw69k5hCDqmvCrs4fqytBXSNZPUuvBisqoglKr4saBGQcldUGAJN41/eI TKftqitQ1a7dwjehQ0YjeDYwZGTBMnN5ExVojseo1w+seDHR7ebu0uxCyUcm4Ukd 0a/OQdlRRxqaMauOFCcMyQMjfE899/1danpcDeymr3BXC0uWgQI5BfeP7vQsaVzm trsyipLHw7POCfaCswXLVfkly8VFrbs3tBjqLUWd4b/yUokfQ6H+RWTvWsJJJLE= =T8hx -----END PGP SIGNATURE----- --+HP7ph2BbKc20aGI-- --===============0004386872== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0004386872==--