From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v3 2/2] dt-bindings: net: Add Cortina device tree bindings Date: Fri, 26 May 2017 15:35:54 +0200 Message-ID: <20170526133554.GD31389@lunn.ch> References: <1495785519-1468-1-git-send-email-bogdan.purcareata@nxp.com> <1495785519-1468-3-git-send-email-bogdan.purcareata@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1495785519-1468-3-git-send-email-bogdan.purcareata-3arQi8VN3Tc@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bogdan Purcareata Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org > + cs4340_phy@1 { > + compatible = "ethernet-phy-id13e5.1002"; > + reg = <0x10>; The @1 and the reg value should be the same. Please change it to cs4340_phy@10. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034375AbdEZNf7 (ORCPT ); Fri, 26 May 2017 09:35:59 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:45630 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030669AbdEZNf5 (ORCPT ); Fri, 26 May 2017 09:35:57 -0400 Date: Fri, 26 May 2017 15:35:54 +0200 From: Andrew Lunn To: Bogdan Purcareata Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] dt-bindings: net: Add Cortina device tree bindings Message-ID: <20170526133554.GD31389@lunn.ch> References: <1495785519-1468-1-git-send-email-bogdan.purcareata@nxp.com> <1495785519-1468-3-git-send-email-bogdan.purcareata@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495785519-1468-3-git-send-email-bogdan.purcareata@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + cs4340_phy@1 { > + compatible = "ethernet-phy-id13e5.1002"; > + reg = <0x10>; The @1 and the reg value should be the same. Please change it to cs4340_phy@10. Andrew