From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755185AbdE0Jq2 (ORCPT ); Sat, 27 May 2017 05:46:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48550 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755159AbdE0Jq0 (ORCPT ); Sat, 27 May 2017 05:46:26 -0400 Date: Sat, 27 May 2017 11:46:16 +0200 From: Greg Kroah-Hartman To: Dmitry Torokhov Cc: Julius Werner , Guenter Roeck , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "firmware: vpd: remove platform driver" Message-ID: <20170527094616.GA15980@kroah.com> References: <20170526205749.GA5706@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170526205749.GA5706@dtor-ws> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 01:57:49PM -0700, Dmitry Torokhov wrote: > This reverts commit 7975bd4cca05a99aa14964cfa22366ee64da50ad, because > VPD relies on driver core to handle deferrals returned by > coreboot_table_find(). > > Signed-off-by: Dmitry Torokhov > Reviewed-by: Guenter Roeck > --- > > Greg, here is the revert we discussed. > > I will look into whether we could make coreboot table not use deferrals, > but some mother mechanism to notify users that the data is available. > The entities we are dealing here with are not really hardware devices > and I consider using platform devices/drivers for them misuse of the > driver model, but for now it needs to stay as it was. If they aren't platform devices, then why just make them "virtual" devices, using a simple device_create() call with no parent? thanks, greg k-h