From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Mon, 29 May 2017 10:48:09 +0200 Subject: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE In-Reply-To: References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> Message-ID: <20170529084809.GA2192@mai> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Mon, May 29, 2017 at 10:41:52AM +0200, Arnd Bergmann wrote: > On Sat, May 27, 2017 at 11:58 AM, Daniel Lezcano > wrote: > > The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the > > clocksource at early stage. However, this macro is also used to initialize > > the clockevent if any, or the clockevent only. > > > > It was originally suggested to declare another macro to initialize a > > clockevent, so in order to separate the two entities even they belong to the > > same IP. This was not accepted because of the impact on the DT where splitting > > a clocksource/clockevent definition does not make sense as it is a Linux > > concept not a hardware description. > > > > On the other side, the clocksource has not interrupt declared while the > > clockevent has, so it is easy from the driver to know if the description is > > for a clockevent or a clocksource, IOW it could be implemented at the driver > > level. > > > > So instead of dealing with a named clocksource macro, let's use a more generic > > one: TIMER_OF_DECLARE. > > > > The patch has not functional changes. > > > > Signed-off-by: Daniel Lezcano > > Could you either leave the old name as an alias for one release, or introduce > the new name as an alias now for 4.13? > > I think that that would make it easier to merge new drivers. Otherwise this > looks good to me, New drivers should go through my tree, so I can catch them with the old macro name and do the change. > Acked-by: Arnd Bergmann Thanks for the review. -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 29 May 2017 10:48:29 +0200 (CEST) Received: from mail-wm0-x236.google.com ([IPv6:2a00:1450:400c:c09::236]:37301 "EHLO mail-wm0-x236.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23993009AbdE2IsVEDAQH (ORCPT ); Mon, 29 May 2017 10:48:21 +0200 Received: by mail-wm0-x236.google.com with SMTP id d127so49751666wmf.0 for ; Mon, 29 May 2017 01:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7tqql2MnZiI9NmTGLxNtZ74cnoEXNq+3EvJRDXfkhYk=; b=QmYa2J0BIhlpyLwLwD7gajUdWsjN8orglmu0PwXjfzu8tcBDjUWeEYqsgG7viFWLrI QXSgDbGSn+kI5udt5x27j6xArxWiyhBikPVmdd8zW2/UePj1hhsWrLrFmRWdh4lJXXrJ KQ9RzksccKWAmIM4Vg+P09PinRpd/lBIO+7jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=7tqql2MnZiI9NmTGLxNtZ74cnoEXNq+3EvJRDXfkhYk=; b=ZHq0/hxjAzPSF7+b39772aP/sNraYqnY1q7fW7Qwur2JEeuJb2BQseekMcGn3c9wKg OG4rjgpVsa7WMC189c5LM+h2kn1n0WH/F2QuEj3Tcq3tdayEuwRQ2zeTz6DpVz26tU3N d1ma0eXBTiEUsUrgMI/5dbR+BcBVKA7G3Lf6KtF1hBk3eQw61Tuqb3lnLqp3dpGr0sdO f65WsaYNhlnI+/q1EnFYY2n+bMGe+eI4h9KlVy9M91B6IFSKZCySGfvfwjGGzghwfeU0 1khPbLLkliAVZxB7Pn5mZe22hWcra3Ju9cIVMZ6/O/4sf/bzl2tgT5sehviDmwCc1+x0 VNTA== X-Gm-Message-State: AODbwcBDZLkLHCC69u5QEfZJvMVblpgmoEHkvG8aDzdz2gI8ooYgVQww utUQxVedoOsw35zz X-Received: by 10.28.111.7 with SMTP id k7mr10184919wmc.50.1496047695121; Mon, 29 May 2017 01:48:15 -0700 (PDT) Received: from mai ([2a01:e35:879a:6cd0:3e97:eff:fe5b:1402]) by smtp.gmail.com with ESMTPSA id x17sm5351302wrd.63.2017.05.29.01.48.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 May 2017 01:48:14 -0700 (PDT) Date: Mon, 29 May 2017 10:48:09 +0200 From: Daniel Lezcano To: Arnd Bergmann Cc: Thomas Gleixner , Linux ARM , Linux Kernel Mailing List , Russell King , Michal Simek , John Crispin , Ralf Baechle , Ley Foon Tan , Vineet Gupta , Mark Rutland , Marc Zyngier , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Florian Fainelli , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Stephen Warren , Lee Jones , Eric Anholt , =?iso-8859-1?Q?S=F6ren?= Brinkmann , Linus Walleij , Alexander Shiyan , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Yoshinori Sato , Carlo Caione , Kevin Hilman , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Matthias Brugger , Heiko Stuebner , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Thierry Reding , Alexandre Courbot , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Joachim Eastwood , Vladimir Zapolskiy , Sylvain Lemieux , Barry Song , Baruch Siach , Santosh Shilimkar , Neil Armstrong , Tony Prisk , John Stultz , Stephen Boyd , Anna-Maria Gleixner , Richard Cochran , Ingo Molnar , Noam Camus , "open list:RALINK MIPS ARCHITECTURE" , "moderated list:NIOS2 ARCHITECTURE" , "open list:SYNOPSYS ARC ARCHITECTURE" , "open list:ARM/STI ARCHITECTURE" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , "moderated list:H8/300 ARCHITECTURE" , "open list:ARM/Amlogic Meson SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/Rockchip SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/OXNAS platform support" Subject: Re: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE Message-ID: <20170529084809.GA2192@mai> References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 58062 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: daniel.lezcano@linaro.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Mon, May 29, 2017 at 10:41:52AM +0200, Arnd Bergmann wrote: > On Sat, May 27, 2017 at 11:58 AM, Daniel Lezcano > wrote: > > The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the > > clocksource at early stage. However, this macro is also used to initialize > > the clockevent if any, or the clockevent only. > > > > It was originally suggested to declare another macro to initialize a > > clockevent, so in order to separate the two entities even they belong to the > > same IP. This was not accepted because of the impact on the DT where splitting > > a clocksource/clockevent definition does not make sense as it is a Linux > > concept not a hardware description. > > > > On the other side, the clocksource has not interrupt declared while the > > clockevent has, so it is easy from the driver to know if the description is > > for a clockevent or a clocksource, IOW it could be implemented at the driver > > level. > > > > So instead of dealing with a named clocksource macro, let's use a more generic > > one: TIMER_OF_DECLARE. > > > > The patch has not functional changes. > > > > Signed-off-by: Daniel Lezcano > > Could you either leave the old name as an alias for one release, or introduce > the new name as an alias now for 4.13? > > I think that that would make it easier to merge new drivers. Otherwise this > looks good to me, New drivers should go through my tree, so I can catch them with the old macro name and do the change. > Acked-by: Arnd Bergmann Thanks for the review. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE Date: Mon, 29 May 2017 10:48:09 +0200 Message-ID: <20170529084809.GA2192@mai> References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Arnd Bergmann Cc: Mark Rutland , "open list:RALINK MIPS ARCHITECTURE" , Baruch Siach , Heiko Stuebner , Neil Armstrong , Linus Walleij , Santosh Shilimkar , Liviu Dudau , "moderated list:ARM/OXNAS platform support" , Patrice Chotard , Eric Anholt , Thierry Reding , Ingo Molnar , "open list:ARM/STI ARCHITECTURE" , Alexandre Courbot , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Florian Fainelli , "moderated list:H8/300 ARCHITECTURE" , Alexander Shiyan List-Id: linux-mediatek@lists.infradead.org T24gTW9uLCBNYXkgMjksIDIwMTcgYXQgMTA6NDE6NTJBTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBPbiBTYXQsIE1heSAyNywgMjAxNyBhdCAxMTo1OCBBTSwgRGFuaWVsIExlemNhbm8K PiA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiBUaGUgQ0xPQ0tTT1VDRV9P Rl9ERUNMQVJFIG1hY3JvIGlzIHVzZWQgd2lkZWx5IGZvciB0aGUgdGltZXJzIHRvIGRlY2xhcmUg dGhlCj4gPiBjbG9ja3NvdXJjZSBhdCBlYXJseSBzdGFnZS4gSG93ZXZlciwgdGhpcyBtYWNybyBp cyBhbHNvIHVzZWQgdG8gaW5pdGlhbGl6ZQo+ID4gdGhlIGNsb2NrZXZlbnQgaWYgYW55LCBvciB0 aGUgY2xvY2tldmVudCBvbmx5Lgo+ID4KPiA+IEl0IHdhcyBvcmlnaW5hbGx5IHN1Z2dlc3RlZCB0 byBkZWNsYXJlIGFub3RoZXIgbWFjcm8gdG8gaW5pdGlhbGl6ZSBhCj4gPiBjbG9ja2V2ZW50LCBz byBpbiBvcmRlciB0byBzZXBhcmF0ZSB0aGUgdHdvIGVudGl0aWVzIGV2ZW4gdGhleSBiZWxvbmcg dG8gdGhlCj4gPiBzYW1lIElQLiBUaGlzIHdhcyBub3QgYWNjZXB0ZWQgYmVjYXVzZSBvZiB0aGUg aW1wYWN0IG9uIHRoZSBEVCB3aGVyZSBzcGxpdHRpbmcKPiA+IGEgY2xvY2tzb3VyY2UvY2xvY2tl dmVudCBkZWZpbml0aW9uIGRvZXMgbm90IG1ha2Ugc2Vuc2UgYXMgaXQgaXMgYSBMaW51eAo+ID4g Y29uY2VwdCBub3QgYSBoYXJkd2FyZSBkZXNjcmlwdGlvbi4KPiA+Cj4gPiBPbiB0aGUgb3RoZXIg c2lkZSwgdGhlIGNsb2Nrc291cmNlIGhhcyBub3QgaW50ZXJydXB0IGRlY2xhcmVkIHdoaWxlIHRo ZQo+ID4gY2xvY2tldmVudCBoYXMsIHNvIGl0IGlzIGVhc3kgZnJvbSB0aGUgZHJpdmVyIHRvIGtu b3cgaWYgdGhlIGRlc2NyaXB0aW9uIGlzCj4gPiBmb3IgYSBjbG9ja2V2ZW50IG9yIGEgY2xvY2tz b3VyY2UsIElPVyBpdCBjb3VsZCBiZSBpbXBsZW1lbnRlZCBhdCB0aGUgZHJpdmVyCj4gPiBsZXZl bC4KPiA+Cj4gPiBTbyBpbnN0ZWFkIG9mIGRlYWxpbmcgd2l0aCBhIG5hbWVkIGNsb2Nrc291cmNl IG1hY3JvLCBsZXQncyB1c2UgYSBtb3JlIGdlbmVyaWMKPiA+IG9uZTogVElNRVJfT0ZfREVDTEFS RS4KPiA+Cj4gPiBUaGUgcGF0Y2ggaGFzIG5vdCBmdW5jdGlvbmFsIGNoYW5nZXMuCj4gPgo+ID4g U2lnbmVkLW9mZi1ieTogRGFuaWVsIExlemNhbm8gPGRhbmllbC5sZXpjYW5vQGxpbmFyby5vcmc+ Cj4gCj4gQ291bGQgeW91IGVpdGhlciBsZWF2ZSB0aGUgb2xkIG5hbWUgYXMgYW4gYWxpYXMgZm9y IG9uZSByZWxlYXNlLCBvciBpbnRyb2R1Y2UKPiB0aGUgbmV3IG5hbWUgYXMgYW4gYWxpYXMgbm93 IGZvciA0LjEzPwo+IAo+IEkgdGhpbmsgdGhhdCB0aGF0IHdvdWxkIG1ha2UgaXQgZWFzaWVyIHRv IG1lcmdlIG5ldyBkcml2ZXJzLiBPdGhlcndpc2UgdGhpcwo+IGxvb2tzIGdvb2QgdG8gbWUsCgoK TmV3IGRyaXZlcnMgc2hvdWxkIGdvIHRocm91Z2ggbXkgdHJlZSwgc28gSSBjYW4gY2F0Y2ggdGhl bSB3aXRoIHRoZSBvbGQgbWFjcm8KbmFtZSBhbmQgZG8gdGhlIGNoYW5nZS4KCj4gQWNrZWQtYnk6 IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+CgpUaGFua3MgZm9yIHRoZSByZXZpZXcuCgot LSAKCiA8aHR0cDovL3d3dy5saW5hcm8ub3JnLz4gTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ug c29mdHdhcmUgZm9yIEFSTSBTb0NzCgpGb2xsb3cgTGluYXJvOiAgPGh0dHA6Ly93d3cuZmFjZWJv b2suY29tL3BhZ2VzL0xpbmFybz4gRmFjZWJvb2sgfAo8aHR0cDovL3R3aXR0ZXIuY29tLyMhL2xp bmFyb29yZz4gVHdpdHRlciB8CjxodHRwOi8vd3d3LmxpbmFyby5vcmcvbGluYXJvLWJsb2cvPiBC bG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tj aGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Mon, 29 May 2017 10:48:09 +0200 Subject: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE In-Reply-To: References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> List-ID: Message-ID: <20170529084809.GA2192@mai> To: linux-snps-arc@lists.infradead.org On Mon, May 29, 2017@10:41:52AM +0200, Arnd Bergmann wrote: > On Sat, May 27, 2017 at 11:58 AM, Daniel Lezcano > wrote: > > The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the > > clocksource at early stage. However, this macro is also used to initialize > > the clockevent if any, or the clockevent only. > > > > It was originally suggested to declare another macro to initialize a > > clockevent, so in order to separate the two entities even they belong to the > > same IP. This was not accepted because of the impact on the DT where splitting > > a clocksource/clockevent definition does not make sense as it is a Linux > > concept not a hardware description. > > > > On the other side, the clocksource has not interrupt declared while the > > clockevent has, so it is easy from the driver to know if the description is > > for a clockevent or a clocksource, IOW it could be implemented at the driver > > level. > > > > So instead of dealing with a named clocksource macro, let's use a more generic > > one: TIMER_OF_DECLARE. > > > > The patch has not functional changes. > > > > Signed-off-by: Daniel Lezcano > > Could you either leave the old name as an alias for one release, or introduce > the new name as an alias now for 4.13? > > I think that that would make it easier to merge new drivers. Otherwise this > looks good to me, New drivers should go through my tree, so I can catch them with the old macro name and do the change. > Acked-by: Arnd Bergmann Thanks for the review. -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog