From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-mtd@lists.infradead.org, andrew@lunn.ch,
computersforpeace@gmail.com, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Subject: Re: [PATCH v4 4/5] mtd: mchp23k256: add partitioning support
Date: Mon, 29 May 2017 11:14:28 +0200 [thread overview]
Message-ID: <20170529111428.6748c2e2@bbrezillon> (raw)
In-Reply-To: <20170524234916.16181-5-chris.packham@alliedtelesis.co.nz>
On Thu, 25 May 2017 11:49:15 +1200
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> Setting the of_node for the mtd device allows the generic mtd code to
> setup the partitions. Additionally we must specify a non-zero erasesize
> for the partitions to be writeable.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Changes in v2
> - collect revew/test from Andrew
> Changes in v3:
> - remove setting of erasesize
> Changes in v4:
> - none
>
> drivers/mtd/devices/mchp23k256.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c
> index 2542f5b8b63f..3e5feb454644 100644
> --- a/drivers/mtd/devices/mchp23k256.c
> +++ b/drivers/mtd/devices/mchp23k256.c
> @@ -143,6 +143,7 @@ static int mchp23k256_probe(struct spi_device *spi)
>
> data = dev_get_platdata(&spi->dev);
>
> + mtd_set_of_node(&flash->mtd, spi->dev.of_node);
> flash->mtd.dev.parent = &spi->dev;
> flash->mtd.type = MTD_RAM;
> flash->mtd.flags = MTD_CAP_RAM;
next prev parent reply other threads:[~2017-05-29 9:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 23:49 [PATCH v4 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Chris Packham
2017-05-24 23:49 ` [PATCH v4 1/5] mtd: mchp23k256: Add OF device ID table Chris Packham
2017-05-24 23:49 ` Chris Packham
2017-05-29 9:13 ` Boris Brezillon
2017-05-29 9:13 ` Boris Brezillon
2017-05-31 17:50 ` Rob Herring
2017-05-24 23:49 ` [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register() Chris Packham
2017-05-29 9:13 ` Boris Brezillon
2017-05-24 23:49 ` [PATCH v4 3/5] mtd: handle partitioning on devices with 0 erasesize Chris Packham
2017-05-29 9:13 ` Boris Brezillon
2017-05-24 23:49 ` [PATCH v4 4/5] mtd: mchp23k256: add partitioning support Chris Packham
2017-05-29 9:14 ` Boris Brezillon [this message]
2017-06-01 18:45 ` Brian Norris
2017-05-24 23:49 ` [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Chris Packham
2017-05-29 9:15 ` Boris Brezillon
2017-05-29 9:15 ` Boris Brezillon
2017-05-31 17:52 ` Rob Herring
2017-05-31 17:52 ` Rob Herring
2017-06-01 18:46 ` [PATCH v4 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170529111428.6748c2e2@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.