All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/google-breakpad: use PRE_CONFIGURE hooks to copy linux_syscall_support.h
Date: Mon, 29 May 2017 22:21:45 +0200	[thread overview]
Message-ID: <20170529222145.3e8adabb@free-electrons.com> (raw)
In-Reply-To: <20170529201329.13455-1-romain.naour@gmail.com>

Hello,

On Mon, 29 May 2017 22:13:29 +0200, Romain Naour wrote:
> As reported by Bernd [1], using POST_EXTRACT to copy
> linux_syscall_support.h break the legal-info target when
> google-breakpad package is selected.
> 
> Step to reproduce:
> 
> Create a foo defconfig with google-breakpad package:
> $ make foo_defconfig

This explanation is a bit weird, you clearly don't need to create a
defconfig to reproduce the problem. You simply need to create any
configuration that has google-breakpad enabled.

> Use PRE_CONFIGURE hooks instead since there are not used by legal-info.

This is not the point. The point is that this linux_syscall_support.h
file is installed by a dependency of google-breakpad, and dependencies
are not guaranteed to be available before the configure step of the
package.

I've applied to master after adjusting the commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-05-29 20:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29 20:13 [Buildroot] [PATCH] package/google-breakpad: use PRE_CONFIGURE hooks to copy linux_syscall_support.h Romain Naour
2017-05-29 20:21 ` Thomas Petazzoni [this message]
2017-06-01 14:31 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529222145.3e8adabb@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.