From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
John Stultz <john.stultz@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: pm8941-pwrkey: Introduce reboot mode support
Date: Mon, 29 May 2017 21:47:11 -0700 [thread overview]
Message-ID: <20170530044711.GP12920@tuxbook> (raw)
In-Reply-To: <20170530025324.GD32841@dtor-ws>
On Mon 29 May 19:53 PDT 2017, Dmitry Torokhov wrote:
> On Fri, May 26, 2017 at 11:51:30PM -0700, Bjorn Andersson wrote:
> > In some Qualcomm platforms the magic for informing LK which mode to
> > reboot into is stored in the PON_SOFT_RB_SPARE register. Register with
> > the reboot mode helpers to expose this to the user.
>
> Hmm, is the power key driver the best place to have this? WHy isn't this
> a driver in its own right?
>
The functionality is part of the "PON" block in the Qualcomm PMICs,
other functionality from this block relates to configuration and
handling related to power-key and reset-key.
Several of these properties are intermingled, so I do believe it's best
to handle them in a single driver; that said, it might no longer be
correct to name the driver "pwrkey" or that it is a "misc input" driver.
Regards,
Bjorn
next prev parent reply other threads:[~2017-05-30 4:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 6:51 [PATCH 1/2] power: reset: reboot-mode: Make include file global Bjorn Andersson
2017-05-27 6:51 ` [PATCH 2/2] Input: pm8941-pwrkey: Introduce reboot mode support Bjorn Andersson
2017-05-30 2:53 ` Dmitry Torokhov
2017-05-30 4:47 ` Bjorn Andersson [this message]
2017-06-08 16:32 ` Sebastian Reichel
2017-06-12 23:32 ` Bjorn Andersson
2017-06-15 16:26 ` Sebastian Reichel
2017-06-15 18:33 ` Bjorn Andersson
2017-06-15 21:38 ` Rob Herring
2017-06-20 14:27 ` Sebastian Reichel
2017-06-08 16:24 ` [PATCH 1/2] power: reset: reboot-mode: Make include file global Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530044711.GP12920@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.