Re: [PATCH v2] net/mlx4: support user space rxq interrupt event

[Adrien Mazarguil <adrien.mazarguil@6wind.com>]

On Sun, May 28, 2017 at 07:11:38PM +0300, Moti Haimovsky wrote:
> Implement rxq interrupt callbacks
> 
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>

Hi Moti,

While this patch is almost identical to its mlx5 counterpart, I have one
minor nit (see below). Besides that:

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

> ---
>  doc/guides/nics/features/mlx4.ini      |   1 +
>  doc/guides/rel_notes/release_17_08.rst |   5 +
>  drivers/net/mlx4/mlx4.c                | 218 ++++++++++++++++++++++++++++++++-
>  drivers/net/mlx4/mlx4.h                |   1 +
>  4 files changed, 219 insertions(+), 6 deletions(-)
[...]
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index ec4419a..95ab325 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -75,6 +75,7 @@
>  #include <rte_memory.h>
>  #include <rte_flow.h>
>  #include <rte_kvargs.h>
> +#include <rte_interrupts.h>
>  
>  /* Generated configuration header. */
>  #include "mlx4_autoconf.h"
> @@ -127,6 +128,30 @@ struct mlx4_conf {
>  	NULL,
>  };
>  
> +static void
> +mlx4_dev_link_status_handler(void *);
> +
> +static void
> +mlx4_dev_interrupt_handler(void *);
> +

I understand the need for a clean up, however these definitions are not
related to this patch.

[...]
>  
> -static void
> -mlx4_dev_link_status_handler(void *);
> -static void
> -mlx4_dev_interrupt_handler(void *);
> -

Please leave them here.

-- 
Adrien Mazarguil
6WIND