From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU
Date: Tue, 30 May 2017 13:41:55 +0200 [thread overview]
Message-ID: <20170530134155.4996efdb@free-electrons.com> (raw)
In-Reply-To: <97989700-2c97-892e-b470-a84af6dfd77b@arm.com>
Hello,
Thanks for the quick review!
On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote:
> > + The 1st cell is the group type of the ICU interrupt (SPI_NSR,
> > + SPI_SR, SEI, and REI).
>
> Is it worth documenting what these are?
Sure, will do.
> > +icu: interrupt-controller at 1e0000 {
> > + compatible = "marvell,icu";
> > + reg = <0x1e0000 0x10>;
> > + #interrupt-cells = <2>;
>
> Oh wait...
Gaah, I did spot this mistake, but then forgot to fix it. Will do.
> > + interrupt-controller;
> > + interrupt-parent = <&gic>;
> > + gicp = <&gicp>;
>
> Should this be prefixed with a vendor specific identifier, just in case?
Would marvell,gicp be preferable?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Hanna Hawa <hannah-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Yehuda Yitschak <yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Antoine Tenart
<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU
Date: Tue, 30 May 2017 13:41:55 +0200 [thread overview]
Message-ID: <20170530134155.4996efdb@free-electrons.com> (raw)
In-Reply-To: <97989700-2c97-892e-b470-a84af6dfd77b-5wv7dgnIgG8@public.gmane.org>
Hello,
Thanks for the quick review!
On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote:
> > + The 1st cell is the group type of the ICU interrupt (SPI_NSR,
> > + SPI_SR, SEI, and REI).
>
> Is it worth documenting what these are?
Sure, will do.
> > +icu: interrupt-controller@1e0000 {
> > + compatible = "marvell,icu";
> > + reg = <0x1e0000 0x10>;
> > + #interrupt-cells = <2>;
>
> Oh wait...
Gaah, I did spot this mistake, but then forgot to fix it. Will do.
> > + interrupt-controller;
> > + interrupt-parent = <&gic>;
> > + gicp = <&gicp>;
>
> Should this be prefixed with a vendor specific identifier, just in case?
Would marvell,gicp be preferable?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Nadav Haklai <nadavh@marvell.com>,
Hanna Hawa <hannah@marvell.com>,
Yehuda Yitschak <yehuday@marvell.com>,
Antoine Tenart <antoine.tenart@free-electrons.com>
Subject: Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU
Date: Tue, 30 May 2017 13:41:55 +0200 [thread overview]
Message-ID: <20170530134155.4996efdb@free-electrons.com> (raw)
In-Reply-To: <97989700-2c97-892e-b470-a84af6dfd77b@arm.com>
Hello,
Thanks for the quick review!
On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote:
> > + The 1st cell is the group type of the ICU interrupt (SPI_NSR,
> > + SPI_SR, SEI, and REI).
>
> Is it worth documenting what these are?
Sure, will do.
> > +icu: interrupt-controller@1e0000 {
> > + compatible = "marvell,icu";
> > + reg = <0x1e0000 0x10>;
> > + #interrupt-cells = <2>;
>
> Oh wait...
Gaah, I did spot this mistake, but then forgot to fix it. Will do.
> > + interrupt-controller;
> > + interrupt-parent = <&gic>;
> > + gicp = <&gicp>;
>
> Should this be prefixed with a vendor specific identifier, just in case?
Would marvell,gicp be preferable?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-30 11:41 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 9:16 [PATCH 0/6] Add support for the ICU unit in Marvell Armada 7K/8K Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 9:16 ` [PATCH 1/6] dt-bindings: interrupt-controller: add DT binding for the Marvell GICP Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 9:16 ` [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 10:37 ` Marc Zyngier
2017-05-30 10:37 ` Marc Zyngier
2017-05-30 10:37 ` Marc Zyngier
2017-05-30 11:41 ` Thomas Petazzoni [this message]
2017-05-30 11:41 ` Thomas Petazzoni
2017-05-30 11:41 ` Thomas Petazzoni
2017-05-30 9:16 ` [PATCH 3/6] irqchip: irq-mvebu-gicp: new driver for Marvell GICP Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 13:55 ` Marc Zyngier
2017-05-30 13:55 ` Marc Zyngier
2017-05-30 13:55 ` Marc Zyngier
2017-05-30 14:54 ` Thomas Petazzoni
2017-05-30 14:54 ` Thomas Petazzoni
2017-05-30 14:54 ` Thomas Petazzoni
2017-05-30 15:17 ` Marc Zyngier
2017-05-30 15:17 ` Marc Zyngier
2017-05-30 15:17 ` Marc Zyngier
2017-05-30 15:25 ` Thomas Petazzoni
2017-05-30 15:25 ` Thomas Petazzoni
2017-05-30 15:33 ` Marc Zyngier
2017-05-30 15:33 ` Marc Zyngier
2017-05-30 15:33 ` Marc Zyngier
2017-05-30 9:16 ` [PATCH 4/6] irqchip: irq-mvebu-icu: new driver for Marvell ICU Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 11:10 ` Marc Zyngier
2017-05-30 11:10 ` Marc Zyngier
2017-05-30 12:05 ` Thomas Petazzoni
2017-05-30 12:05 ` Thomas Petazzoni
2017-05-30 12:05 ` Thomas Petazzoni
2017-05-30 13:06 ` Marc Zyngier
2017-05-30 13:06 ` Marc Zyngier
2017-05-30 13:06 ` Marc Zyngier
2017-05-30 13:17 ` Thomas Petazzoni
2017-05-30 13:17 ` Thomas Petazzoni
2017-05-30 13:17 ` Thomas Petazzoni
2017-05-30 13:40 ` Marc Zyngier
2017-05-30 13:40 ` Marc Zyngier
2017-06-25 6:47 ` [EXT] " Yehuda Yitschak
2017-06-25 6:47 ` Yehuda Yitschak
2017-05-30 12:04 ` Antoine Tenart
2017-05-30 12:04 ` Antoine Tenart
2017-05-30 12:04 ` Antoine Tenart
2017-05-30 12:19 ` Russell King - ARM Linux
2017-05-30 12:19 ` Russell King - ARM Linux
2017-05-30 12:19 ` Russell King - ARM Linux
2017-05-30 12:33 ` Thomas Petazzoni
2017-05-30 12:33 ` Thomas Petazzoni
2017-05-30 12:33 ` Thomas Petazzoni
2017-05-30 12:56 ` Russell King - ARM Linux
2017-05-30 12:56 ` Russell King - ARM Linux
2017-05-30 12:56 ` Russell King - ARM Linux
2017-05-30 13:27 ` Andrew Lunn
2017-05-30 13:27 ` Andrew Lunn
2017-05-30 13:27 ` Andrew Lunn
2017-05-30 13:34 ` Thomas Petazzoni
2017-05-30 13:34 ` Thomas Petazzoni
2017-05-30 13:34 ` Thomas Petazzoni
2017-05-30 13:42 ` Russell King - ARM Linux
2017-05-30 13:42 ` Russell King - ARM Linux
2017-05-30 13:42 ` Russell King - ARM Linux
2017-05-30 14:03 ` Andrew Lunn
2017-05-30 14:03 ` Andrew Lunn
2017-05-30 14:03 ` Andrew Lunn
2017-05-30 14:36 ` Russell King - ARM Linux
2017-05-30 14:36 ` Russell King - ARM Linux
2017-05-30 14:36 ` Russell King - ARM Linux
2017-05-30 14:26 ` Thomas Petazzoni
2017-05-30 14:26 ` Thomas Petazzoni
2017-05-30 14:26 ` Thomas Petazzoni
2017-05-30 14:39 ` Russell King - ARM Linux
2017-05-30 14:39 ` Russell King - ARM Linux
2017-05-30 14:39 ` Russell King - ARM Linux
2017-05-30 14:49 ` Andrew Lunn
2017-05-30 14:49 ` Andrew Lunn
2017-05-30 14:49 ` Andrew Lunn
2017-05-30 15:08 ` Russell King - ARM Linux
2017-05-30 15:08 ` Russell King - ARM Linux
2017-05-30 13:28 ` Thomas Petazzoni
2017-05-30 13:28 ` Thomas Petazzoni
2017-05-30 13:28 ` Thomas Petazzoni
2017-05-30 9:16 ` [PATCH 5/6] arm64: marvell: enable ICU and GICP drivers Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 9:16 ` [PATCH 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 14:02 ` Marc Zyngier
2017-05-30 14:02 ` Marc Zyngier
2017-05-30 14:02 ` Marc Zyngier
2017-05-30 14:28 ` Thomas Petazzoni
2017-05-30 14:28 ` Thomas Petazzoni
2017-05-30 14:28 ` Thomas Petazzoni
2017-05-30 9:16 ` [PATCH 6/6] arm64: dts: marvell: enable GICP and ICU Thomas Petazzoni
2017-05-30 9:16 ` Thomas Petazzoni
2017-05-30 9:22 ` Thomas Petazzoni
2017-05-30 9:22 ` Thomas Petazzoni
2017-05-30 9:22 ` Thomas Petazzoni
2017-05-30 14:15 ` [PATCH 0/6] Add support for the ICU unit in Marvell Armada 7K/8K Marc Zyngier
2017-05-30 14:15 ` Marc Zyngier
2017-05-30 14:15 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530134155.4996efdb@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.