From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Tue, 30 May 2017 13:41:55 +0200 Subject: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU In-Reply-To: <97989700-2c97-892e-b470-a84af6dfd77b@arm.com> References: <1496135772-20694-1-git-send-email-thomas.petazzoni@free-electrons.com> <1496135772-20694-3-git-send-email-thomas.petazzoni@free-electrons.com> <97989700-2c97-892e-b470-a84af6dfd77b@arm.com> Message-ID: <20170530134155.4996efdb@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, Thanks for the quick review! On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote: > > + The 1st cell is the group type of the ICU interrupt (SPI_NSR, > > + SPI_SR, SEI, and REI). > > Is it worth documenting what these are? Sure, will do. > > +icu: interrupt-controller at 1e0000 { > > + compatible = "marvell,icu"; > > + reg = <0x1e0000 0x10>; > > + #interrupt-cells = <2>; > > Oh wait... Gaah, I did spot this mistake, but then forgot to fix it. Will do. > > + interrupt-controller; > > + interrupt-parent = <&gic>; > > + gicp = <&gicp>; > > Should this be prefixed with a vendor specific identifier, just in case? Would marvell,gicp be preferable? Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU Date: Tue, 30 May 2017 13:41:55 +0200 Message-ID: <20170530134155.4996efdb@free-electrons.com> References: <1496135772-20694-1-git-send-email-thomas.petazzoni@free-electrons.com> <1496135772-20694-3-git-send-email-thomas.petazzoni@free-electrons.com> <97989700-2c97-892e-b470-a84af6dfd77b@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <97989700-2c97-892e-b470-a84af6dfd77b-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marc Zyngier Cc: Thomas Gleixner , Jason Cooper , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Nadav Haklai , Hanna Hawa , Yehuda Yitschak , Antoine Tenart List-Id: devicetree@vger.kernel.org Hello, Thanks for the quick review! On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote: > > + The 1st cell is the group type of the ICU interrupt (SPI_NSR, > > + SPI_SR, SEI, and REI). > > Is it worth documenting what these are? Sure, will do. > > +icu: interrupt-controller@1e0000 { > > + compatible = "marvell,icu"; > > + reg = <0x1e0000 0x10>; > > + #interrupt-cells = <2>; > > Oh wait... Gaah, I did spot this mistake, but then forgot to fix it. Will do. > > + interrupt-controller; > > + interrupt-parent = <&gic>; > > + gicp = <&gicp>; > > Should this be prefixed with a vendor specific identifier, just in case? Would marvell,gicp be preferable? Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751050AbdE3Ll7 (ORCPT ); Tue, 30 May 2017 07:41:59 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:48829 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbdE3Ll5 (ORCPT ); Tue, 30 May 2017 07:41:57 -0400 Date: Tue, 30 May 2017 13:41:55 +0200 From: Thomas Petazzoni To: Marc Zyngier Cc: Thomas Gleixner , Jason Cooper , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , linux-arm-kernel@lists.infradead.org, Nadav Haklai , Hanna Hawa , Yehuda Yitschak , Antoine Tenart Subject: Re: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU Message-ID: <20170530134155.4996efdb@free-electrons.com> In-Reply-To: <97989700-2c97-892e-b470-a84af6dfd77b@arm.com> References: <1496135772-20694-1-git-send-email-thomas.petazzoni@free-electrons.com> <1496135772-20694-3-git-send-email-thomas.petazzoni@free-electrons.com> <97989700-2c97-892e-b470-a84af6dfd77b@arm.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Thanks for the quick review! On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote: > > + The 1st cell is the group type of the ICU interrupt (SPI_NSR, > > + SPI_SR, SEI, and REI). > > Is it worth documenting what these are? Sure, will do. > > +icu: interrupt-controller@1e0000 { > > + compatible = "marvell,icu"; > > + reg = <0x1e0000 0x10>; > > + #interrupt-cells = <2>; > > Oh wait... Gaah, I did spot this mistake, but then forgot to fix it. Will do. > > + interrupt-controller; > > + interrupt-parent = <&gic>; > > + gicp = <&gicp>; > > Should this be prefixed with a vendor specific identifier, just in case? Would marvell,gicp be preferable? Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com