From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org, lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] migration: Allow unregister of save_live handlers
Date: Tue, 30 May 2017 15:47:42 +0100 [thread overview]
Message-ID: <20170530144742.GI2120@work-vm> (raw)
In-Reply-To: <87wp965w1g.fsf@secure.mitica>
* Juan Quintela (quintela@redhat.com) wrote:
> Peter Xu <peterx@redhat.com> wrote:
> > On Wed, May 24, 2017 at 01:21:52PM +0200, Juan Quintela wrote:
> >> Migration non save_live handlers have an ops member that is
> >> dinamically allocated by migration code. Save_live handlers have it
> >> passed as argument and are responsability of the caller. Add a new
> >> member is_allocated that remembers if ops has to be freed. This
> >> allows unregister_savevm() to work with save_live handlers.
> >>
> >> Signed-off-by: Juan Quintela <quintela@redhat.com>
> >
> > I thought Laurent will prepare one patch that will directly remove
> > existing register_savevm() callers, no?
>
> s390, vmxnet3 and slirp are using it. I am not sure that we will get
> that ones "changed" so easily.
I think Halil is working on s390, slirp has a tricky loop I need to
look at again. And vmxnet3 is...odd.
Dave
> Later, Juan.
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2017-05-30 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 11:21 [Qemu-devel] [PATCH v2] migration: Allow unregister of save_live handlers Juan Quintela
2017-05-24 11:24 ` Peter Xu
2017-05-24 11:33 ` Juan Quintela
2017-05-30 14:47 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530144742.GI2120@work-vm \
--to=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.