From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751758AbdE3PIQ (ORCPT ); Tue, 30 May 2017 11:08:16 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58284 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbdE3PIP (ORCPT ); Tue, 30 May 2017 11:08:15 -0400 Date: Tue, 30 May 2017 17:08:13 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 0/7] net: dsa: tagger simplification Message-ID: <20170530150813.GE22758@lunn.ch> References: <20170530142131.23568-1-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170530142131.23568-1-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2017 at 10:21:24AM -0400, Vivien Didelot wrote: > The DSA layer has a dsa_device_ops structure containing two members to > tag and untag the proprietary switch header, called xmit and rcv. > > The switch tree and slave private structures respectively hold a useless > copy of the rcv and xmit functions. The tagging implementations use > useless goto labels and only the rcv caller (partially) handles the SKB > freeing. The rcv function also contains unused arguments. > > This patchset removes the copy of rcv and xmit functions, the unused > arguments of the rcv signature and the useless labels, and handles > freeing of the SKB in the xmit caller. Hi Vivien Since these changes are dealing with the hot path of the network stack, it would be good to see some performance results. In particular, from a high performance machine, 10Gbps interfaces, where DSA is enabled, as a distro kernel might have. Andrew