From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Honza Petrouš" <jpetrous@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 0/3] mtd:nor:ppb_unlock fixes
Date: Tue, 30 May 2017 15:24:01 +0200 [thread overview]
Message-ID: <20170530152401.750d42e2@bbrezillon> (raw)
In-Reply-To: <CAJbz7-0+WijkdxuwL_xvjwTWfzWcqL5PHAqSwGbwV=txQVnnAA@mail.gmail.com>
On Tue, 30 May 2017 11:51:07 +0200
Honza Petrouš <jpetrous@gmail.com> wrote:
> Hi Boris,
> as you advised I come back with v2 patch, now it is the series
> of three fixes I found them during the testing of the original fix.
>
> From the fixes it is evident that PPB unlocking is not so much
> widely used. What is understandable as usually the flashing
> is done in bootloader. At least in projects I was involved before.
>
> Anyway, I can say I tested the code only on one-flashchip
> configuration, so I'm not 100% sure if all will be ok with multichip
> setting. All my old embedded boards have unfortunatelly only
> one nor chip.
I think I found another bug here [1]. The test does not work for
multichip flashes because adr is set back to 0 when you cross a chip
boundary.
If you want my opinion, you'd better re-code the whole logic (you can
probably do better, but here is an example [2]).
[1]http://elixir.free-electrons.com/linux/v4.12-rc3/source/drivers/mtd/chips/cfi_cmdset_0002.c#L2668
[2]http://code.bulix.org/35oaxp-140047
next prev parent reply other threads:[~2017-05-30 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 9:51 [PATCH v2 0/3] mtd:nor:ppb_unlock fixes Honza Petrouš
2017-05-30 9:59 ` Boris Brezillon
2017-05-30 11:01 ` Honza Petrouš
2017-05-30 11:32 ` Boris Brezillon
2017-05-30 13:24 ` Boris Brezillon [this message]
2017-06-04 16:18 ` Honza Petrouš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530152401.750d42e2@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=jpetrous@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.