From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 7/7] net: dsa: factor skb freeing on xmit
Date: Tue, 30 May 2017 17:37:08 +0200 [thread overview]
Message-ID: <20170530153708.GI22758@lunn.ch> (raw)
In-Reply-To: <20170530142131.23568-8-vivien.didelot@savoirfairelinux.com>
On Tue, May 30, 2017 at 10:21:31AM -0400, Vivien Didelot wrote:
> The taggers are currently responsible to free the original SKB if they
> made a copy of it, or in case of error.
>
> This patch simplifies this by freeing the original SKB in the
> dsa_slave_xmit caller if it differs from the return SKB (copy or NULL.)
So we have two different things here:
1) The tagger needs to drop the frame, because there is an error of
some sort.
2) The tagger allocates a new skb for the frame.
I think on error, the core code can drop the frame.
If the tagger allocates a new skb, i think the tagger should be
responsible for freeing to original.
Andrew
next prev parent reply other threads:[~2017-05-30 15:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 14:21 [PATCH net-next 0/7] net: dsa: tagger simplification Vivien Didelot
2017-05-30 14:21 ` [PATCH net-next 1/7] net: dsa: hide dsa_uses_tagged_protocol code Vivien Didelot
2017-05-30 15:01 ` Andrew Lunn
2017-05-30 15:09 ` David Miller
2017-05-30 15:56 ` Vivien Didelot
2017-05-30 16:12 ` Andrew Lunn
2017-05-30 16:14 ` Vivien Didelot
2017-05-30 21:08 ` kbuild test robot
2017-05-30 14:21 ` [PATCH net-next 2/7] net: dsa: remove useless rcv copy in DSA tree Vivien Didelot
2017-05-30 15:05 ` Andrew Lunn
2017-05-30 15:09 ` David Miller
2017-05-30 14:21 ` [PATCH net-next 3/7] net: dsa: remove unused arguments of tagger rcv Vivien Didelot
2017-05-30 15:13 ` Andrew Lunn
2017-05-30 14:21 ` [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated Vivien Didelot
2017-05-30 15:25 ` Andrew Lunn
2017-05-30 15:41 ` Vivien Didelot
2017-05-30 16:26 ` Andrew Lunn
2017-05-30 14:21 ` [PATCH net-next 5/7] net: dsa: remove useless goto label in tagger rcv Vivien Didelot
2017-05-30 14:21 ` [PATCH net-next 6/7] net: dsa: remove useless copy of tagger xmit Vivien Didelot
2017-05-30 15:29 ` Andrew Lunn
2017-05-30 15:43 ` Vivien Didelot
2017-05-30 14:21 ` [PATCH net-next 7/7] net: dsa: factor skb freeing on xmit Vivien Didelot
2017-05-30 15:37 ` Andrew Lunn [this message]
2017-05-30 15:08 ` [PATCH net-next 0/7] net: dsa: tagger simplification Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530153708.GI22758@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.