From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Stephen Bates" <sbates@raithlin.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Vinod Koul" <vinod.koul@intel.com>,
"Per Förlin" <per.forlin@axis.com>
Subject: [PATCH v2 2/2] dmaengine: ste_dma40: Cleanup scatterlist layering violations
Date: Tue, 30 May 2017 16:39:17 -0600 [thread overview]
Message-ID: <20170530223917.6643-2-logang@deltatee.com> (raw)
In-Reply-To: <20170530223917.6643-1-logang@deltatee.com>
This dma engine driver directly accesses page_link assuming knowledge
that should be contained only in scatterlist.h.
We replace this access with a call to sg_chain which is equivalent.
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Stephen Bates <sbates@raithlin.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Per Förlin <per.forlin@axis.com>
---
v2: Splits the patch into two: one per driver
drivers/dma/ste_dma40.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index a6620b671d1d..c3052fbfd092 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2528,10 +2528,7 @@ dma40_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t dma_addr,
dma_addr += period_len;
}
- sg[periods].offset = 0;
- sg_dma_len(&sg[periods]) = 0;
- sg[periods].page_link =
- ((unsigned long)sg | 0x01) & ~0x02;
+ sg_chain(sg, periods + 1, sg);
txd = d40_prep_sg(chan, sg, sg, periods, direction,
DMA_PREP_INTERRUPT);
--
2.11.0
next prev parent reply other threads:[~2017-05-30 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 22:39 [PATCH v2 1/2] dmaengine: imx-dma: cleanup scatterlist layering violations Logan Gunthorpe
2017-05-30 22:39 ` Logan Gunthorpe [this message]
2017-06-01 16:39 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530223917.6643-2-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=per.forlin@axis.com \
--cc=sbates@raithlin.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.