All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: dm-devel@redhat.com, Shaohua Li <shli@kernel.org>
Subject: Re: [PATCH 1/2] dm: Make flush bios explicitely sync
Date: Wed, 31 May 2017 10:53:51 -0400	[thread overview]
Message-ID: <20170531145350.GA16914@redhat.com> (raw)
In-Reply-To: <20170531074433.14298-2-jack@suse.cz>

On Wed, May 31 2017 at  3:44am -0400,
Jan Kara <jack@suse.cz> wrote:

> Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as
> synchronous" removed REQ_SYNC flag from WRITE_{FUA|PREFLUSH|...}
> definitions.  generic_make_request_checks() however strips REQ_FUA and
> REQ_PREFLUSH flags from a bio when the storage doesn't report volatile
> write cache and thus write effectively becomes asynchronous which can
> lead to performance regressions
> 
> Fix the problem by making sure all bios which are synchronous are
> properly marked with REQ_SYNC.
> 
> CC: Mike Snitzer <snitzer@redhat.com>
> CC: dm-devel@redhat.com
> Fixes: b685d3d65ac791406e0dfd8779cc9b3707fea5a3
> CC: stable@vger.kernel.org
> Signed-off-by: Jan Kara <jack@suse.cz>

thanks, staged for 4.12-rc4

  reply	other threads:[~2017-05-31 14:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31  7:44 [PATCH 0/2 v2] Fix fallout from changes to FUA and PREFLUSH definitions Jan Kara
2017-05-31  7:44 ` [PATCH 1/2] dm: Make flush bios explicitely sync Jan Kara
2017-05-31 14:53   ` Mike Snitzer [this message]
2017-05-31  7:44 ` [PATCH 2/2] md: " Jan Kara
2017-05-31 16:23   ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531145350.GA16914@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=jack@suse.cz \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.