From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH V1 11/15] spmi: spmi-pmic-arb: enable the SPMI interrupt as a wakeup source Date: Wed, 31 May 2017 10:13:58 -0700 Message-ID: <20170531171358.GC20170@codeaurora.org> References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-12-git-send-email-kgunda@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1496147943-25822-12-git-send-email-kgunda@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Kiran Gunda Cc: Abhijeet Dharmapurikar , Christophe JAILLET , David Collins , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com, Nicholas Troast List-Id: linux-arm-msm@vger.kernel.org On 05/30, Kiran Gunda wrote: > Currently the SPMI interrupt will not wake the device. Enable this > interrupt as a wakeup source. > > Signed-off-by: Nicholas Troast > Signed-off-by: Kiran Gunda > --- > drivers/spmi/spmi-pmic-arb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c > index 0deac33..2afe359 100644 > --- a/drivers/spmi/spmi-pmic-arb.c > +++ b/drivers/spmi/spmi-pmic-arb.c > @@ -1140,6 +1140,7 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev) > } > > irq_set_chained_handler_and_data(pa->irq, pmic_arb_chained_irq, pa); > + enable_irq_wake(pa->irq); Why don't we do this through an irq_set_wake callback in the irqchip? That way, we don't mark this irq as wakeup if any child irqs aren't marked as wakeup. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project