All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Eric Ruei <e-ruei1@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [morty/master][PATCH] gstreamer1.0-plugins-bad: Apply gstwaylandsink scale-up issue fix to AM3/4
Date: Wed, 31 May 2017 13:39:36 -0400	[thread overview]
Message-ID: <20170531173936.GO28136@edge> (raw)
In-Reply-To: <1495754790-61777-1-git-send-email-e-ruei1@ti.com>

Eric,

This breaks builds for am3x:

| ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c: In function 'gst_wl_window_resize_video_surface':
| ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:255:22: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop'
|    if (window->display->crop) {
|                       ^~
| ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:256:72: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop'
|      wl_viewport_set_destination (window->area_viewport, window->display->crop->width,  window->display->crop->height);
|                                                                         ^~
| ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:256:103: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop'
|      wl_viewport_set_destination (window->area_viewport, window->display->crop->width,  window->display->crop->height);
|                                                                                                        ^~
| ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:257:73: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop'
|      wl_viewport_set_destination (window->video_viewport, window->display->crop->width,  window->display->crop->height);
|                                                                          ^~
| ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:257:104: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop'
|      wl_viewport_set_destination (window->video_viewport, window->display->crop->width,  window->display->crop->height);
|                                                                                                         ^~
| Makefile:935: recipe for target 'libgstwaylandsink_la-wlwindow.lo' failed
| make[3]: *** [libgstwaylandsink_la-wlwindow.lo] Error 1
| make[3]: *** Waiting for unfinished jobs....
| ../../../gst-plugins-bad-1.8.3/ext/wayland/wldisplay.c:299:6: warning: no previous prototype for 'pointer_axis_stop' [-Wmissing-prototypes]
|  void pointer_axis_stop(void *data, struct wl_pointer *wl_pointer, uint32_t time, uint32_t axis)
|       ^~~~~~~~~~~~~~~~~
| make[3]: Leaving directory '/OE/arago-morty-next-build/build-CORTEX_1/arago-tmp-external-linaro-toolchain/work/am335x_evm-linux-gnueabi/gstreamer1.0-plugins-bad/1.8.3-r5/build/ext/wayland'
| Makefile:1331: recipe for target 'wayland' failed
| make[2]: *** [wayland] Error 2

Full logs:
http://lcpd.gt.design.ti.com/builds/arago-morty-next/systest/am335x-evm/17645/logs/am335x-evm-error-logs/gstreamer1.0-plugins-bad_1.8.3-r5_do_compile.log


On Thu, May 25, 2017 at 07:26:30PM -0400, Eric Ruei wrote:
> Pick the patch:
> 1. 0006-gstwaylandsink-Fix-scale-up-with-padded-video.patch
> 
> Signed-off-by: Pooja Prajod <a0132412@ti.com>
> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-bad_1.8.3.bbappend                   | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.8.3.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.8.3.bbappend
> index ff61132..3e6c8a5 100644
> --- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.8.3.bbappend
> +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.8.3.bbappend
> @@ -28,11 +28,13 @@ SRC_URI_append_ti43x = " \
>      file://0003-kmssink-add-YUYV-support.patch \
>      file://0001-gstwaylandsink-add-input-format-I420-support.patch \
>      file://0005-gstwaylandsink-Implement-callbacks-for-version-5-of-.patch \
> +    file://0006-gstwaylandsink-Fix-scale-up-with-padded-video.patch \
>  "
>  
>  SRC_URI_append_ti33x = " \
>      file://0001-gstwaylandsink-Add-mouse-drag-and-drop-support.patch \
>      file://0005-gstwaylandsink-Implement-callbacks-for-version-5-of-.patch \
> +    file://0006-gstwaylandsink-Fix-scale-up-with-padded-video.patch \
>  "
>  
>  SRC_URI_append_omap-a15 = " \
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


  reply	other threads:[~2017-05-31 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 23:26 [morty/master][PATCH] gstreamer1.0-plugins-bad: Apply gstwaylandsink scale-up issue fix to AM3/4 Eric Ruei
2017-05-31 17:39 ` Denys Dmytriyenko [this message]
2017-05-31 19:01   ` Ruei, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531173936.GO28136@edge \
    --to=denys@ti.com \
    --cc=e-ruei1@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.