From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure Date: Wed, 31 May 2017 12:02:10 -0700 Message-ID: <20170531190209.GK3730@atomide.com> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-6-hannes@cmpxchg.org> <20170531171450.GA10481@cmpxchg.org> <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Johannes Weiner , Josef Bacik , Michal Hocko , Vladimir Davydov , Rik van Riel , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org, Russell King , Yury Norov , Stephen Rothwell * Andrew Morton [170531 11:21]: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > > Can you include the following fix on top of this patch please? Thanks! > > OK. But this won't fix the init ordering crash which the arm folks are > seeing? That's correct, the ordering crash is a separate problem. > I'm wondering if we should ask Stephen to drop > > mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch > mm-memcontrol-use-the-node-native-slab-memory-counters.patch > mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch > mm-memcontrol-per-lruvec-stats-infrastructure.patch > mm-memcontrol-account-slab-stats-per-lruvec.patch > > until that is sorted? Seems like a good idea. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f71.google.com (mail-it0-f71.google.com [209.85.214.71]) by kanga.kvack.org (Postfix) with ESMTP id 233696B02F3 for ; Wed, 31 May 2017 15:02:17 -0400 (EDT) Received: by mail-it0-f71.google.com with SMTP id l6so1316433iti.0 for ; Wed, 31 May 2017 12:02:17 -0700 (PDT) Received: from muru.com (muru.com. [72.249.23.125]) by mx.google.com with ESMTP id u17si48886364plj.231.2017.05.31.12.02.15 for ; Wed, 31 May 2017 12:02:15 -0700 (PDT) Date: Wed, 31 May 2017 12:02:10 -0700 From: Tony Lindgren Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure Message-ID: <20170531190209.GK3730@atomide.com> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-6-hannes@cmpxchg.org> <20170531171450.GA10481@cmpxchg.org> <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Johannes Weiner , Josef Bacik , Michal Hocko , Vladimir Davydov , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Russell King , Yury Norov , Stephen Rothwell * Andrew Morton [170531 11:21]: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > > Can you include the following fix on top of this patch please? Thanks! > > OK. But this won't fix the init ordering crash which the arm folks are > seeing? That's correct, the ordering crash is a separate problem. > I'm wondering if we should ask Stephen to drop > > mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch > mm-memcontrol-use-the-node-native-slab-memory-counters.patch > mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch > mm-memcontrol-per-lruvec-stats-infrastructure.patch > mm-memcontrol-account-slab-stats-per-lruvec.patch > > until that is sorted? Seems like a good idea. Regards, Tony -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751118AbdEaTCR (ORCPT ); Wed, 31 May 2017 15:02:17 -0400 Received: from muru.com ([72.249.23.125]:49976 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdEaTCP (ORCPT ); Wed, 31 May 2017 15:02:15 -0400 Date: Wed, 31 May 2017 12:02:10 -0700 From: Tony Lindgren To: Andrew Morton Cc: Johannes Weiner , Josef Bacik , Michal Hocko , Vladimir Davydov , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Russell King , Yury Norov , Stephen Rothwell Subject: Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure Message-ID: <20170531190209.GK3730@atomide.com> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-6-hannes@cmpxchg.org> <20170531171450.GA10481@cmpxchg.org> <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531111821.14ebeee4a4181583fe6fac46@linux-foundation.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andrew Morton [170531 11:21]: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > > Can you include the following fix on top of this patch please? Thanks! > > OK. But this won't fix the init ordering crash which the arm folks are > seeing? That's correct, the ordering crash is a separate problem. > I'm wondering if we should ask Stephen to drop > > mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch > mm-memcontrol-use-the-node-native-slab-memory-counters.patch > mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch > mm-memcontrol-per-lruvec-stats-infrastructure.patch > mm-memcontrol-account-slab-stats-per-lruvec.patch > > until that is sorted? Seems like a good idea. Regards, Tony