From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: netdev@vger.kernel.org, davem@davemloft.net, stephen@networkplumber.org
Subject: Re: [PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"
Date: Wed, 31 May 2017 18:07:57 -0400 [thread overview]
Message-ID: <20170531220757.GI9362@oracle.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1705312337280.5775@ja.home.ssi.bg>
On (06/01/17 00:41), Julian Anastasov wrote:
>
> So, we do not hold reference to neigh while accessing
> its fields. I suspect we need to move the table lock from
> neigh_remove_one here, for example:
Another thought is to have neigh_remove_one to remove
a neigh only if it is NUD_FAILED - that may potentially remove
more than one entry, but that's probably harmless?
--Sowmini
next prev parent reply other threads:[~2017-05-31 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 23:52 [PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d" Sowmini Varadhan
2017-05-31 21:41 ` Julian Anastasov
2017-05-31 21:46 ` Sowmini Varadhan
2017-05-31 22:41 ` Julian Anastasov
2017-06-01 1:21 ` Sowmini Varadhan
2017-05-31 22:07 ` Sowmini Varadhan [this message]
2017-05-31 23:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531220757.GI9362@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.