All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] edu: fix memory leak on msi_broken platforms
Date: Thu, 1 Jun 2017 11:12:53 +0800	[thread overview]
Message-ID: <20170601031253.GD32741@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170531125746.17585-1-pbonzini@redhat.com>

On Wed, May 31, 2017 at 02:57:46PM +0200, Paolo Bonzini wrote:
> If msi_init fails, the thread has already been created and the
> mutex/condvar are not destroyed.  Initialize everything only
> after the point where pci_edu_realize cannot fail.
> 
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Cc: Peter Xu <peterx@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu

      parent reply	other threads:[~2017-06-01  3:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 12:57 [Qemu-devel] [PATCH] edu: fix memory leak on msi_broken platforms Paolo Bonzini
2017-05-31 13:50 ` Markus Armbruster
2017-06-01  3:12 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170601031253.GD32741@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.