From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 1 Jun 2017 08:08:04 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Omar Sandoval Subject: Re: [PATCH v2 12/12] block: Rename blk_mq_rq_{to,from}_pdu() Message-ID: <20170601060804.GE16248@lst.de> References: <20170531225246.26261-1-bart.vanassche@sandisk.com> <20170531225246.26261-13-bart.vanassche@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170531225246.26261-13-bart.vanassche@sandisk.com> List-ID: On Wed, May 31, 2017 at 03:52:46PM -0700, Bart Van Assche wrote: > Commit 6d247d7f71d1 ("block: allow specifying size for extra command > data") added support for .cmd_size to blk-sq. Due to that patch the > blk_mq_rq_{to,from}_pdu() functions are also useful for single-queue > block drivers. Hence remove "_mq" from the name of these functions. > This patch does not change any functionality. Most of this patch has > been generated by running the following shell command: I don't really see the point of this as it's primarily a blk-mq API and we still hope to get rid of the old code. But I'm not necessarily against it either.