From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Thu, 1 Jun 2017 08:33:54 +0200 Subject: [PATCH v1 1/7] nvme: rename uuid to nguid in nvme_ns In-Reply-To: <7e97c34f8ab586615cb57b22a36db2eeb0ccc57f.1496237370.git.jthumshirn@suse.de> References: <7e97c34f8ab586615cb57b22a36db2eeb0ccc57f.1496237370.git.jthumshirn@suse.de> Message-ID: <20170601063354.GA16778@lst.de> On Wed, May 31, 2017@03:32:11PM +0200, Johannes Thumshirn wrote: > The uuid field in the nvme_ns structure represents the nguid field > from the identify namespace command. And as NVMe 1.3 introduced an > UUID in the NVMe Namespace Identification Descriptor this will > collide. > > So rename the uuid to nguid to prevent any further > confusion. Unfortunately we export the nguid to sysfs in the uuid > sysfs attribute, but this can't be changed anymore without possibly > breaking existing userspace. > > Signed-off-by: Johannes Thumshirn Looks fine, Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751176AbdFAGd4 (ORCPT ); Thu, 1 Jun 2017 02:33:56 -0400 Received: from verein.lst.de ([213.95.11.211]:44401 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdFAGd4 (ORCPT ); Thu, 1 Jun 2017 02:33:56 -0400 Date: Thu, 1 Jun 2017 08:33:54 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Hannes Reinecke , Max Gurtovoy , Linux NVMe Mailinglist , Linux Kernel Mailinglist Subject: Re: [PATCH v1 1/7] nvme: rename uuid to nguid in nvme_ns Message-ID: <20170601063354.GA16778@lst.de> References: <7e97c34f8ab586615cb57b22a36db2eeb0ccc57f.1496237370.git.jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e97c34f8ab586615cb57b22a36db2eeb0ccc57f.1496237370.git.jthumshirn@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2017 at 03:32:11PM +0200, Johannes Thumshirn wrote: > The uuid field in the nvme_ns structure represents the nguid field > from the identify namespace command. And as NVMe 1.3 introduced an > UUID in the NVMe Namespace Identification Descriptor this will > collide. > > So rename the uuid to nguid to prevent any further > confusion. Unfortunately we export the nguid to sysfs in the uuid > sysfs attribute, but this can't be changed anymore without possibly > breaking existing userspace. > > Signed-off-by: Johannes Thumshirn Looks fine, Reviewed-by: Christoph Hellwig