From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: mm: don't print out page table entries on EL0 faults
Date: Thu, 1 Jun 2017 13:37:50 +0100 [thread overview]
Message-ID: <20170601123750.GG12832@arm.com> (raw)
In-Reply-To: <59b82477-b937-0ffb-6cf1-d86e9b0488ba@arm.com>
On Wed, May 31, 2017 at 08:38:00PM +0100, Kristina Martsenko wrote:
> On 22/05/17 13:21, Will Deacon wrote:
> > On Mon, May 22, 2017 at 12:45:54PM +0100, Kristina Martsenko wrote:
> >> When we take a fault from EL0 that can't be handled, we print out the
> >> page table entries associated with the faulting address. This allows
> >> userspace to print out any current page table entries, including kernel
> >> (TTBR1) entries. Exposing kernel mappings like this could pose a
> >> security risk, so don't print out page table information on EL0 faults.
> >> (But still print it out for EL1 faults.)
> >>
> >> Signed-off-by: Kristina Martsenko <kristina.martsenko@arm.com>
> >
> > It might be worth mentioning that this follows the same behaviour as x86.
>
> Yep.
>
> > In fact, they print the name of the faulting VMA using print_vma_addr,
> > which might be useful too.
>
> Looks useful, should I add that in a separate patch in v2?
Sure, works for me.
Will
next prev parent reply other threads:[~2017-06-01 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 11:45 [PATCH 1/2] arm64: mm: print out correct page table entries Kristina Martsenko
2017-05-22 11:45 ` [PATCH 2/2] arm64: mm: don't print out page table entries on EL0 faults Kristina Martsenko
2017-05-22 12:21 ` Will Deacon
2017-05-31 19:38 ` Kristina Martsenko
2017-06-01 12:37 ` Will Deacon [this message]
2017-05-22 12:18 ` [PATCH 1/2] arm64: mm: print out correct page table entries Will Deacon
2017-05-31 19:37 ` Kristina Martsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601123750.GG12832@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.