From: Jean Delvare <jdelvare@suse.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
bbaude@redhat.com, mildred-bug.kernel@mildred.fr,
barnacs@justletit.be, lvuksta@gmail.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Kelly French <kfrench@federalhill.net>
Subject: Re: [PATCH v2 1/3] firmware: dmi: Add DMI_PRODUCT_FAMILY identification string
Date: Thu, 1 Jun 2017 14:42:54 +0200 [thread overview]
Message-ID: <20170601144254.142be515@endymion> (raw)
In-Reply-To: <20170517102514.89744-2-mika.westerberg@linux.intel.com>
I did not notice before, but now that I'm testing...
On Wed, 17 May 2017 13:25:12 +0300, Mika Westerberg wrote:
> --- a/drivers/firmware/dmi-id.c
> +++ b/drivers/firmware/dmi-id.c
> @@ -47,6 +47,7 @@ DEFINE_DMI_ATTR_WITH_SHOW(product_name, 0444, DMI_PRODUCT_NAME);
> DEFINE_DMI_ATTR_WITH_SHOW(product_version, 0444, DMI_PRODUCT_VERSION);
> DEFINE_DMI_ATTR_WITH_SHOW(product_serial, 0400, DMI_PRODUCT_SERIAL);
> DEFINE_DMI_ATTR_WITH_SHOW(product_uuid, 0400, DMI_PRODUCT_UUID);
> +DEFINE_DMI_ATTR_WITH_SHOW(product_family, 0400, DMI_PRODUCT_FAMILY);
> DEFINE_DMI_ATTR_WITH_SHOW(board_vendor, 0444, DMI_BOARD_VENDOR);
> DEFINE_DMI_ATTR_WITH_SHOW(board_name, 0444, DMI_BOARD_NAME);
> DEFINE_DMI_ATTR_WITH_SHOW(board_version, 0444, DMI_BOARD_VERSION);
I see no reason to hide this field from users. Permissions 0444 would
seem more appropriate. I'll include that change in my patch if there
are no objections.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-06-01 12:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 10:25 [PATCH v2 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems Mika Westerberg
2017-05-17 10:25 ` [PATCH v2 1/3] firmware: dmi: Add DMI_PRODUCT_FAMILY identification string Mika Westerberg
2017-05-17 10:31 ` Andy Shevchenko
2017-05-23 8:05 ` Linus Walleij
2017-06-01 9:29 ` Jean Delvare
2017-06-01 10:09 ` Mika Westerberg
2017-06-01 10:54 ` Jean Delvare
2017-06-01 11:05 ` Mika Westerberg
2017-06-01 12:42 ` Jean Delvare [this message]
2017-05-17 10:25 ` [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables Mika Westerberg
2017-05-17 10:30 ` Andy Shevchenko
2017-05-23 8:08 ` Linus Walleij
2017-06-01 9:30 ` Jean Delvare
2017-06-09 8:53 ` Linus Walleij
2017-05-17 10:25 ` [PATCH v2 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Mika Westerberg
2017-05-17 10:28 ` Andy Shevchenko
2017-05-23 8:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601144254.142be515@endymion \
--to=jdelvare@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=barnacs@justletit.be \
--cc=bbaude@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfrench@federalhill.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvuksta@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mildred-bug.kernel@mildred.fr \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.