All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Gerow <gerow@google.com>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH] video: fbdev: udlfb: drop log level for blanking
Date: Thu, 01 Jun 2017 20:25:59 +0000	[thread overview]
Message-ID: <20170601202559.GA96809@google.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

Log blanking that goes from FB_BLANK_UNBLANK to itself at debug. It turns
out Xorg likes to habitually unblank when already unblanked and this can
fill up logs over a long period of time.

Signed-off-by: Mike Gerow <gerow@google.com>
---
 drivers/video/fbdev/udlfb.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 6a3c353de7c3..611de916abcf 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -1105,8 +1105,17 @@ static int dlfb_ops_blank(int blank_mode, struct fb_info *info)
 	char *bufptr;
 	struct urb *urb;
 
-	pr_info("/dev/fb%d FB_BLANK mode %d --> %d\n",
-		info->node, dev->blank_mode, blank_mode);
+	/*
+	 * Xorg likes to habitually unblank when already unblanked so log these
+	 * kinds of events at debug.
+	 */
+	if (dev->blank_mode == FB_BLANK_UNBLANK &&
+	    blank_mode == FB_BLANK_UNBLANK)
+		pr_debug("/dev/fb%d FB_BLANK mode %d --> %d (FB_BLANK_UNBLANK --> FB_BLANK_UNBLANK)\n",
+			 info->node, FB_BLANK_UNBLANK, FB_BLANK_UNBLANK);
+	else
+		pr_info("/dev/fb%d FB_BLANK mode %d --> %d\n",
+			info->node, dev->blank_mode, blank_mode);
 
 	if ((dev->blank_mode == FB_BLANK_POWERDOWN) &&
 	    (blank_mode != FB_BLANK_POWERDOWN)) {
-- 
2.13.0.219.gdb65acc882-goog


-- 
Mike Gerow
gerow@google.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

             reply	other threads:[~2017-06-01 20:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 20:25 Mike Gerow [this message]
2017-06-01 20:38 ` [PATCH] video: fbdev: udlfb: drop log level for blanking Mike Gerow
2017-06-07 13:33 ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170601202559.GA96809@google.com \
    --to=gerow@google.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.