From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
Cc: sboyd@codeaurora.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v5 4/4] remoteproc: qcom: Add support for mss remoteproc on msm8996
Date: Thu, 1 Jun 2017 13:33:24 -0700 [thread overview]
Message-ID: <20170601203324.GA12920@tuxbook> (raw)
In-Reply-To: <1496344641-6291-5-git-send-email-akdwived@codeaurora.org>
On Thu 01 Jun 12:17 PDT 2017, Avaneesh Kumar Dwivedi wrote:
> This patch add support for mss boot on msm8996. Major changes
> include initializing mss rproc for msm8996, making appropriate
> change for executing mss reset sequence etc.
>
> Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
> ---
> .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 1 +
> drivers/remoteproc/qcom_q6v5_pil.c | 163 ++++++++++++++++++---
> 2 files changed, 140 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> index 92347fe..87a8e51 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> @@ -11,6 +11,7 @@ on the Qualcomm Hexagon core.
> "qcom,msm8916-mss-pil",
> "qcom,msm8974-mss-pil"
This blank line should be moved one step down.
> + "qcom,msm8996-mss-pil"
> - reg:
> Usage: required
> Value type: <prop-encoded-array>
Apart from that I think this looks good.
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
prev parent reply other threads:[~2017-06-01 20:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 19:17 [PATCH v5 0/4] Add memory ownership switch support and enable mss rproc on msm8996 Avaneesh Kumar Dwivedi
2017-06-01 19:17 ` [PATCH v5 1/4] firmware: scm: Add new SCM call API for switching memory ownership Avaneesh Kumar Dwivedi
2017-06-01 20:30 ` Bjorn Andersson
2017-06-02 18:22 ` Stephen Boyd
2017-06-07 16:06 ` Dwivedi, Avaneesh Kumar (avani)
2017-06-01 19:17 ` [PATCH v5 2/4] remoteproc: qcom: refactor mss fw image loading sequence Avaneesh Kumar Dwivedi
2017-06-01 20:32 ` Bjorn Andersson
2017-06-01 19:17 ` [PATCH v5 3/4] remoteproc: qcom: Make secure world call for mem ownership switch Avaneesh Kumar Dwivedi
2017-06-01 20:42 ` Bjorn Andersson
2017-06-01 21:42 ` Dwivedi, Avaneesh Kumar (avani)
2017-06-02 17:55 ` Bjorn Andersson
2017-06-07 16:27 ` Dwivedi, Avaneesh Kumar (avani)
2017-06-07 21:20 ` Bjorn Andersson
2017-06-01 19:17 ` [PATCH v5 4/4] remoteproc: qcom: Add support for mss remoteproc on msm8996 Avaneesh Kumar Dwivedi
2017-06-01 20:33 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601203324.GA12920@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=agross@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.