From: Brian Norris <computersforpeace@gmail.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Subject: Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support
Date: Thu, 1 Jun 2017 15:23:20 -0700 [thread overview]
Message-ID: <20170601222320.GE102137@google.com> (raw)
In-Reply-To: <bba73e6d5f4b41a88423287300d892e5@svr-chch-ex1.atlnz.lc>
On Thu, Jun 01, 2017 at 09:30:07PM +0000, Chris Packham wrote:
> On 02/06/17 06:43, Brian Norris wrote:
> > On Wed, May 17, 2017 at 05:29:11PM +0200, Boris Brezillon wrote:
> >> Can we fix allocate_partition() to properly handle the
> >> master->erasesize == 0 case instead of doing that?
> >
> > Is everything actually ready for the eraseblock size to be 0?
>
> That was my initial motivation for faking it.
Understood. I think it's probably better to avoid hacking drivers like
you were about to, but I was also curious if anyone had thought through
the implications of *not* forcing a non-zero size.
> > That would
> > seem surprising to many applications, I would think. Can you, for
> > instance, even use UBI on such a device?
>
> I've tried ext2 and I believe Andrew has tried minix fs. We're talking
> SRAM so UBI/UBIFS doesn't really provide much benefit for this use-case.
Right. But that's not necessarily true for all NO_ERASE devices, so we'd
probably want to think about that before allowing it.
Brian
next prev parent reply other threads:[~2017-06-01 22:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 5:39 [PATCH 0/4] mtd: mchp23k256: device tree and mchp23lcv1024 Chris Packham
2017-05-17 5:39 ` [PATCH 1/4] mtd: mchp23k256: Add OF device ID table Chris Packham
2017-05-17 5:39 ` Chris Packham
2017-05-17 11:44 ` Andrew Lunn
2017-05-17 11:44 ` Andrew Lunn
2017-05-17 5:39 ` [PATCH 2/4] mtd: mchp23k256: switch to mtd_device_register() Chris Packham
2017-05-17 11:48 ` Andrew Lunn
2017-05-17 5:39 ` [PATCH 3/4] mtd: mchp23k256: add partitioning support Chris Packham
2017-05-17 14:18 ` Andrew Lunn
2017-05-17 15:29 ` Boris Brezillon
2017-05-22 4:52 ` Chris Packham
2017-05-22 7:38 ` Boris Brezillon
2017-06-01 18:43 ` Brian Norris
2017-06-01 20:47 ` Boris Brezillon
2017-06-01 22:01 ` Brian Norris
2017-06-02 9:04 ` Boris Brezillon
2017-06-08 23:21 ` Brian Norris
2017-06-01 21:30 ` Chris Packham
2017-06-01 22:23 ` Brian Norris [this message]
2017-06-01 23:08 ` Chris Packham
2017-06-08 23:18 ` Brian Norris
2017-05-17 5:39 ` [PATCH 4/4] mtd: mchp23k256: Add support for mchp23lcv1024 Chris Packham
2017-05-17 12:17 ` Andrew Lunn
2017-05-18 4:36 ` Chris Packham
2017-05-18 4:36 ` Chris Packham
2017-05-17 11:41 ` [PATCH 0/4] mtd: mchp23k256: device tree and mchp23lcv1024 Andrew Lunn
2017-05-17 14:19 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601222320.GE102137@google.com \
--to=computersforpeace@gmail.com \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.