Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

["Du, Changbin" <changbin.du@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote:
> On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin.du@intel.com wrote:
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index 5762ae4..69eea3a 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> >  	if (sort__mode == SORT_MODE__DIFF)
> >  		return keys;
> >  
> > +	if (strstr(keys, "overhead"))
> > +		return keys;
> > +
> >  	keys = prefix_if_not_in("overhead", keys);
> 
> hum, you basicaly do what's at begining of prefix_if_not_in function:
> 
> static char *prefix_if_not_in(const char *pre, char *str)
> {
>         char *n;
> 
>         if (!str || strstr(str, pre))
>                 return str;
>         ...
> 
Thanks, will change it.

> 
> could you please provide the example described in changelog?
> 
Will add example cmdline there, Thanks.

> jirka

-- 
Thanks,
Changbin Du

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]