From: David Gibson <david@gibson.dropbear.id.au>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: lvivier@redhat.com, nikunj@linux.vnet.ibm.com,
sursingh@redhat.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
bharata@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 3/4] spapr: Abolish DRC set_configured method
Date: Fri, 2 Jun 2017 13:31:03 +1000 [thread overview]
Message-ID: <20170602033103.GL13397@umbus.fritz.box> (raw)
In-Reply-To: <149633145975.3207.486309081928645378@loki>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Thu, Jun 01, 2017 at 10:37:39AM -0500, Michael Roth wrote:
> Quoting David Gibson (2017-05-31 20:52:17)
> > DRConnectorClass has a set_configured method, however:
> > * There is only one implementation, and only ever likely to be one
> > * There's exactly one caller, and that's (now) local
> > * The implementation is very straightforward
> >
> > So abolish the method entirely, and just open-code what we need. We also
> > remove the tracepoints associated with it, since they don't look to be
> > terribly useful.
>
> Dropping the method makes sense, but the 'configured' state affects a
> lot of the state-transitions throughout the code so I think it may
> be useful to keep the traces.
Fair point, I'll put the traces back in.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-02 7:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 1:52 [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I) David Gibson
2017-06-01 1:52 ` [Qemu-devel] [PATCH 1/4] spapr: Move DRC RTAS calls into spapr_drc.c David Gibson
2017-06-01 13:36 ` Laurent Vivier
2017-06-01 16:05 ` Michael Roth
2017-06-02 3:21 ` David Gibson
2017-06-01 15:56 ` Michael Roth
2017-06-02 3:24 ` David Gibson
2017-06-01 16:08 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-06-01 1:52 ` [Qemu-devel] [PATCH 2/4] spapr: Abolish DRC get_fdt method David Gibson
2017-06-01 14:01 ` Laurent Vivier
2017-06-01 16:09 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-06-01 1:52 ` [Qemu-devel] [PATCH 3/4] spapr: Abolish DRC set_configured method David Gibson
2017-06-01 15:13 ` Laurent Vivier
2017-06-01 15:37 ` Michael Roth
2017-06-02 3:31 ` David Gibson [this message]
2017-06-01 16:14 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-06-01 1:52 ` [Qemu-devel] [PATCH 4/4] spapr: Make DRC get_index and get_type methods into plain functions David Gibson
2017-06-01 15:19 ` Laurent Vivier
2017-06-01 4:06 ` [Qemu-devel] [PATCH 0/4] spapr:DRC cleanups (part I) Bharata B Rao
2017-06-01 4:21 ` David Gibson
2017-06-01 4:25 ` Michael Roth
2017-06-01 5:30 ` David Gibson
2017-06-01 15:41 ` [Qemu-devel] [Qemu-ppc] " Daniel Henrique Barboza
2017-06-02 3:35 ` David Gibson
2017-06-01 13:41 ` Daniel Henrique Barboza
2017-06-02 3:49 ` [Qemu-devel] " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602033103.GL13397@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=bharata@linux.vnet.ibm.com \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sursingh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.