Re: [Qemu-devel] [PULL 00/22] Docker and block patches

[Fam Zheng <famz@redhat.com>]

On Thu, 06/01 18:18, Peter Maydell wrote:
> On 26 May 2017 at 08:52, Fam Zheng <famz@redhat.com> wrote:
> > The following changes since commit 9964e96dc9999cf7f7c936ee854a795415d19b60:
> >
> >   Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging (2017-05-23 15:01:31 +0100)
> >
> > are available in the git repository at:
> >
> >   git://github.com/famz/qemu.git tags/docker-and-block-pull-request
> >
> > for you to fetch changes up to 77269bba94ef97de99ae61fdc98629a8704ae2ed:
> >
> >   block: make accounting thread-safe (2017-05-26 09:25:30 +0800)
> >
> > ----------------------------------------------------------------
> >
> > For Paolo's block layer thread safety part I and my docker testing
> > enhancements.
> >
> > ----------------------------------------------------------------
> 
> Hi. I'm afraid this doesn't build on BSD or OSX:
> 
> libqemuutil.a(stats64.o): In function `stat64_rdlock':
> /root/qemu/util/stats64.c:24: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In funclibqemuutil.a(stats64.o): In function
> `stat64_rdlock':
> /root/qemu/util/stats64.c:24: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In function `stat64_add32_carry':
> /root/qemu/util/stats64.c:64: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In function `stat64_min_slow':
> /root/qemu/util/stats64.c:85: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In function `stat64_max_slow':
> /root/qemu/util/stats64.c:114: undefined reference to `cpu_relax'
> tilibqemuutil.a(stats64.o): In function `stat64_rdlock':
> /root/qemu/util/stats64.c:24: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In function `stat64_add32_carry':
> /root/qemu/util/stats64.c:64: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In function `stat64_min_slow':
> /root/qemu/util/stats64.c:85: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In function `stat64_max_slow':
> /root/qemu/util/stats64.c:114: undefined reference to `cpu_relax'
> on `stat64_add32_carry':
> /root/qemu/util/stats64.c:64: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In function `stat64_min_slow':
> /root/qemu/util/stats64.c:85: undefined reference to `cpu_relax'
> libqemuutil.a(stats64.o): In function `stat64_max_slow':
> /root/qemu/util/stats64.c:114: undefined reference to `cpu_relax'
> 
> 
> and
> /Users/pm215/src/qemu-for-merges/util/stats64.c:24:9: error: implicit
> declaration of function 'cpu_relax' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
>         cpu_relax();
>         ^
> 
> 
> Looks like an omitted include of qemu/processor.h ?

Yes, including this one works for me, I'll add it and send v2. Thanks,

Fam