From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v5 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback Date: Fri, 2 Jun 2017 11:35:25 +0200 Message-ID: <20170602113525.484caa94@bbrezillon> References: <95fd6c06c58bd0b957e36a8d7068e6a74b581304.1495720737.git.joabreu@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 654A86E069 for ; Fri, 2 Jun 2017 09:35:27 +0000 (UTC) In-Reply-To: <95fd6c06c58bd0b957e36a8d7068e6a74b581304.1495720737.git.joabreu@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jose Abreu Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Carlos Palminha List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyNSBNYXkgMjAxNyAxNToxOToyMSArMDEwMApKb3NlIEFicmV1IDxKb3NlLkFicmV1 QHN5bm9wc3lzLmNvbT4gd3JvdGU6Cgo+IE5vdyB0aGF0IHdlIGhhdmUgYSBjYWxsYmFjayB0byBj aGVjayBpZiBjcnRjIHN1cHBvcnRzIGEgZ2l2ZW4gbW9kZQo+IHdlIGNhbiB1c2UgaXQgaW4gYXRt ZWwtaGxjZGMgc28gdGhhdCB3ZSByZXN0cmljdCB0aGUgbnVtYmVyIG9mIHByb2JiZWQKPiBtb2Rl cyB0byB0aGUgb25lcyB3ZSBjYW4gYWN0dWFsbHkgZGlzcGxheS4KPiAKPiBBbHNvLCByZW1vdmUg dGhlIG1vZGVfZml4dXAoKSBjYWxsYmFjayBhcyB0aGlzIGlzIG5vIGxvbmdlciBuZWVkZWQKPiBi ZWNhdXNlIG1vZGVfdmFsaWQoKSB3aWxsIGJlIGNhbGxlZCBiZWZvcmUuCj4gCj4gTk9URTogTm90 IGV2ZW4gY29tcGlsZWQgdGVzdGVkCgpBcHBsaWVkIHRvIGRybS1taXNjLW5leHQgYWZ0ZXIgZml4 aW5nIGEgY29tcGlsYXRpb24gd2FybmluZyBhbmQKcmVmb3JtYXRpbmcgdG8gY2hlY2twYXRjaCBo YXBweS4KClRoYW5rcywKCkJvcmlzCgo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvc2UgQWJyZXUgPGpv YWJyZXVAc3lub3BzeXMuY29tPgo+IENjOiBDYXJsb3MgUGFsbWluaGEgPHBhbG1pbmhhQHN5bm9w c3lzLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBD YzogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AZnJlZS1lbGVjdHJvbnMuY29tPgo+ IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9hdG1lbC1obGNkYy9hdG1lbF9obGNkY19jcnRjLmMgfCA5ICsrKystLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMvYXRtZWxfaGxjZGNfY3J0Yy5jIGIvZHJp dmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjL2F0bWVsX2hsY2RjX2NydGMuYwo+IGluZGV4IDUzYmZh NTYuLmJkZmU3NGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjL2F0 bWVsX2hsY2RjX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hdG1lbC1obGNkYy9hdG1l bF9obGNkY19jcnRjLmMKPiBAQCAtMTQwLDEzICsxNDAsMTIgQEAgc3RhdGljIHZvaWQgYXRtZWxf aGxjZGNfY3J0Y19tb2RlX3NldF9ub2ZiKHN0cnVjdCBkcm1fY3J0YyAqYykKPiAgCQkJICAgY2Zn KTsKPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wgYXRtZWxfaGxjZGNfY3J0Y19tb2RlX2ZpeHVwKHN0 cnVjdCBkcm1fY3J0YyAqYywKPiAtCQkJCQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAq bW9kZSwKPiAtCQkJCQlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRfbW9kZSkKPiAr c3RhdGljIGVudW0gZHJtX21vZGVfc3RhdHVzIGF0bWVsX2hsY2RjX2NydGNfbW9kZV92YWxpZChz dHJ1Y3QgZHJtX2NydGMgKmMsCj4gKwkJCQkJCQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9k ZSAqbW9kZSkKPiAgewo+ICAJc3RydWN0IGF0bWVsX2hsY2RjX2NydGMgKmNydGMgPSBkcm1fY3J0 Y190b19hdG1lbF9obGNkY19jcnRjKGMpOwo+ICAKPiAtCXJldHVybiBhdG1lbF9obGNkY19kY19t b2RlX3ZhbGlkKGNydGMtPmRjLCBhZGp1c3RlZF9tb2RlKSA9PSBNT0RFX09LOwo+ICsJcmV0dXJu IGF0bWVsX2hsY2RjX2RjX21vZGVfdmFsaWQoY3J0Yy0+ZGMsIG1vZGUpOwo+ICB9Cj4gIAo+ICBz dGF0aWMgdm9pZCBhdG1lbF9obGNkY19jcnRjX2Rpc2FibGUoc3RydWN0IGRybV9jcnRjICpjKQo+ IEBAIC0zMTUsNyArMzE0LDcgQEAgc3RhdGljIHZvaWQgYXRtZWxfaGxjZGNfY3J0Y19hdG9taWNf Zmx1c2goc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICB9Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3Ry dWN0IGRybV9jcnRjX2hlbHBlcl9mdW5jcyBsY2RjX2NydGNfaGVscGVyX2Z1bmNzID0gewo+IC0J Lm1vZGVfZml4dXAgPSBhdG1lbF9obGNkY19jcnRjX21vZGVfZml4dXAsCj4gKwkubW9kZV92YWxp ZCA9IGF0bWVsX2hsY2RjX2NydGNfbW9kZV92YWxpZCwKPiAgCS5tb2RlX3NldCA9IGRybV9oZWxw ZXJfY3J0Y19tb2RlX3NldCwKPiAgCS5tb2RlX3NldF9ub2ZiID0gYXRtZWxfaGxjZGNfY3J0Y19t b2RlX3NldF9ub2ZiLAo+ICAJLm1vZGVfc2V0X2Jhc2UgPSBkcm1faGVscGVyX2NydGNfbW9kZV9z ZXRfYmFzZSwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751294AbdFBJfu (ORCPT ); Fri, 2 Jun 2017 05:35:50 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35167 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbdFBJfr (ORCPT ); Fri, 2 Jun 2017 05:35:47 -0400 Date: Fri, 2 Jun 2017 11:35:25 +0200 From: Boris Brezillon To: Jose Abreu Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Carlos Palminha , Daniel Vetter , David Airlie Subject: Re: [PATCH v5 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback Message-ID: <20170602113525.484caa94@bbrezillon> In-Reply-To: <95fd6c06c58bd0b957e36a8d7068e6a74b581304.1495720737.git.joabreu@synopsys.com> References: <95fd6c06c58bd0b957e36a8d7068e6a74b581304.1495720737.git.joabreu@synopsys.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 May 2017 15:19:21 +0100 Jose Abreu wrote: > Now that we have a callback to check if crtc supports a given mode > we can use it in atmel-hlcdc so that we restrict the number of probbed > modes to the ones we can actually display. > > Also, remove the mode_fixup() callback as this is no longer needed > because mode_valid() will be called before. > > NOTE: Not even compiled tested Applied to drm-misc-next after fixing a compilation warning and reformating to checkpatch happy. Thanks, Boris > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Daniel Vetter > Cc: Boris Brezillon > Cc: David Airlie > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index 53bfa56..bdfe74e 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -140,13 +140,12 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) > cfg); > } > > -static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *c, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +static enum drm_mode_status atmel_hlcdc_crtc_mode_valid(struct drm_crtc *c, > + const struct drm_display_mode *mode) > { > struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c); > > - return atmel_hlcdc_dc_mode_valid(crtc->dc, adjusted_mode) == MODE_OK; > + return atmel_hlcdc_dc_mode_valid(crtc->dc, mode); > } > > static void atmel_hlcdc_crtc_disable(struct drm_crtc *c) > @@ -315,7 +314,7 @@ static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc, > } > > static const struct drm_crtc_helper_funcs lcdc_crtc_helper_funcs = { > - .mode_fixup = atmel_hlcdc_crtc_mode_fixup, > + .mode_valid = atmel_hlcdc_crtc_mode_valid, > .mode_set = drm_helper_crtc_mode_set, > .mode_set_nofb = atmel_hlcdc_crtc_mode_set_nofb, > .mode_set_base = drm_helper_crtc_mode_set_base,